Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send error - second try with different server #720

Merged
merged 12 commits into from
Oct 10, 2024

Conversation

juanky201271
Copy link
Contributor

@juanky201271 juanky201271 commented Oct 8, 2024

on top of: #719

How works: When you send funds to someone and the command confirm give an error, then the App look for the best working server (could be the same if the error is not related with the server itself) and try again.

It's worth it to try twice, because in some cases the send is going to work the seconds time.

Additional tasks:

  • gradle/actions/setup-gradle@v4 - avoiding a new warning.
  • history line when the transaction is confirming fixed. (transmitted vs mempool).
  • custom server with 30 sec timeout.

@juanky201271 juanky201271 self-assigned this Oct 8, 2024
@juanky201271 juanky201271 marked this pull request as ready for review October 10, 2024 19:21
dorianvp
dorianvp previously approved these changes Oct 10, 2024
@juanky201271 juanky201271 merged commit 0888420 into zingolabs:dev Oct 10, 2024
45 of 60 checks passed
@juanky201271 juanky201271 deleted the dev_send_error_second_try branch October 10, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants