Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Zennies for Zingo address #668

Merged
merged 12 commits into from
Jul 25, 2024

Conversation

juanky201271
Copy link
Contributor

@juanky201271 juanky201271 commented Jul 18, 2024

The App have a new UA only for Zennies to Zingo, and these value transfers won't have memo.
To identify them the App automatically add this Address to the address book with this label: Zenny Tips.
This new UA will be protected only for exclusive use of ZingoLabs, and it will be the last one of the list.

IOS: Native address picker list fixed, the list is scroll-able until you tap on the button Done, and then the address change in the send screen. UI/UX problem reported by @zancas

The ZFZ address is frozen in the address book.
Screenshot_20240723_104407

No memo in the Value Transfer.
Screenshot_20240723_104326

Can't be use the protected ZFZ address in send screen.
Screenshot_20240723_104941

@juanky201271 juanky201271 force-pushed the dev_new_zennies_address branch from a70a984 to ac6bc57 Compare July 19, 2024 02:59
@juanky201271 juanky201271 self-assigned this Jul 19, 2024
@juanky201271 juanky201271 marked this pull request as ready for review July 19, 2024 20:06
@juanky201271 juanky201271 force-pushed the dev_new_zennies_address branch from d97bb3f to af1ba49 Compare July 19, 2024 20:30
@juanky201271 juanky201271 assigned zancas and unassigned juanky201271 Jul 23, 2024
zancas
zancas previously approved these changes Jul 23, 2024
Copy link
Member

@zancas zancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Oscar-Pepper can you please review this?

Oscar-Pepper
Oscar-Pepper previously approved these changes Jul 24, 2024
@juanky201271 juanky201271 dismissed stale reviews from Oscar-Pepper and zancas via 504cdb2 July 24, 2024 18:35
@juanky201271 juanky201271 force-pushed the dev_new_zennies_address branch from 9781f4c to 504cdb2 Compare July 24, 2024 18:35
@Oscar-Pepper Oscar-Pepper merged commit 5794730 into zingolabs:dev Jul 25, 2024
19 checks passed
@juanky201271 juanky201271 deleted the dev_new_zennies_address branch July 31, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants