Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing next version: 1.3.7 #616

Merged
merged 59 commits into from
Mar 29, 2024

Conversation

juanky201271
Copy link
Contributor

@juanky201271 juanky201271 commented Mar 17, 2024

  • Refactored code: Avoiding re-renders.
  • Address picker: When the user change from a valid address to another address the App shows an Alert to inform the user of what is going on here and prevent the user can lose a valid address in the send screen.
  • Adding a short text to address book icon Add to, because maybe the user doesn't understand what is for that icon in the send screen when you copy-paste or scan a UA.
  • No periods in settings options.
  • This bugfix included: Bugfix 618 #619
  • This bugfix included: Bugfix 620 #622
  • Donation to developers new Feature. (temporary mainnet UA added). This feature is only available for mainnet servers.
  • Zingo Logo in QR codes.
  • Replicate servers feature from Zingo-pc. fix for: Add new Global lightwalletd servers from Nighthawk #419.
  • The arrow icon in addresses with contact means send. Make the icon bigger.
  • Sapling spendable amount in Pools screen should be yellow to express: this amount should be in orchard.
  • Put an X icon in the fields. The user can clear a specific field.
  • These numbers: .05 (0.05) have to be a valid numbers. Different texts for invalid number & invalid amount.
  • The server list in settings is really long and difficult to manage, we need a select field picker.
  • New server for the list: https://test.zec.rocks:443.
  • Address QR visible in Private mode but without the zingo logo.
  • Unify Restore from Seed & Restore from UFVK in one screen.
  • Stop syncing process just before to run rescan, fix for: Rescan while the App is still Syncing - Do nothing #601.
  • Stop syncing process just before to run change to another wallet & restore last wallet backup, fix for: Change to another wallet while syncing - The wallet file is blocked sometimes. #610.
  • Checking the Ufvk/Seed in lowercase - Restore wallet screen.

TODO:

  • miriaBTC price. (some work in zingolib needed, I guess) @zancas
  • Adaptation for ZIP 317 & 320. @zancas

@juanky201271 juanky201271 linked an issue Mar 18, 2024 that may be closed by this pull request
@juanky201271 juanky201271 force-pushed the dev_refactoring_code branch 3 times, most recently from 447259c to 47225b7 Compare March 19, 2024 15:06
@juanky201271 juanky201271 force-pushed the dev_refactoring_code branch from 1960cbb to 467be2e Compare March 19, 2024 22:36
@juanky201271 juanky201271 changed the title Preparing next version: 1.3.6 Preparing next version: 1.3.7 Mar 20, 2024
@juanky201271 juanky201271 force-pushed the dev_refactoring_code branch from a64d188 to e165276 Compare March 20, 2024 02:45
@juanky201271 juanky201271 linked an issue Mar 27, 2024 that may be closed by this pull request
@juanky201271 juanky201271 marked this pull request as ready for review March 29, 2024 17:32
Copy link
Member

@zancas zancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanky201271 juanky201271 merged commit 6a76431 into zingolabs:dev Mar 29, 2024
12 of 15 checks passed
@juanky201271 juanky201271 deleted the dev_refactoring_code branch March 29, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants