Marketplace: Improve the UI #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zspencer
commented
Oct 2, 2022
Co-authored-by: Neer Thapa <nirmalathapa@users.noreply.github.com>
Co-authored-by: Neer Thapa <nirmalathapa@users.noreply.github.com>
This makes the user experience for adding a product even tighter; by hiding the Product form until the Distributor is adding a new product. Once they do, we replace the entire marketplace with the New Product form; and upon successful create, we replace the entire marketplace with the full Marketplace view! Co-authored-by: Neer Thapa <nirmalathapa@users.noreply.github.com>
Add alt text to spotlight Tried to add alt text as attribute but isn't working. plz help. * Spotlight: Use `"attr"` rather than `:attr` when setting Alt Text So, it turns out there's a pretty nasty wart in the `furniture` implementation where setting the data requires you to know the type of the key being set in the dictionary. That's pretty gross, and probably something we should fix at the architectural level, since it's cost us a ton of brain-space already and we're only just writing our first few bits of Furniture. That said, in the meantime as you add additional attributes to the Image item, we should be able to follow the pattern of using string keys. Co-authored-by: Ana Ulin <anaulin@users.noreply.github.com> Co-authored-by: Zee Spencer <zspencer@users.noreply.github.com>
Still need to figure out how to redirect to furniture Co-authored-by: Kelly <KellyAH@users.noreply.github.com> Co-authored-by: Zee <zspencer@users.noreply.github.com> Co-authored-by: Ana <anaulin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.