Marketplace: Products Controller persists Products! #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This starts to shift our Furniture and Item system away from an inheritance oriented rails-adjacent structure to a more Rails-forward structure. Furniture now places it's routes against the *room*, which allows it to support either Singleton-type Resource routes, or more traditional Resources routes. Further, it brings the `Placeable` interface a bit closer to ActiveRecord; which should reduce pain-points as we unwind the current overly-restrictive and complex Furniture/Item design.
ffe5713 to
714bd48
Compare
mweitzel
reviewed
Oct 1, 2022
| expect(created_product.price_currency).to eql(Money.default_currency.to_s) | ||
| end | ||
| end | ||
| end |
|
Ohhhh yea!!! |
anaulin
approved these changes
Oct 1, 2022
| end | ||
|
|
||
| factory :marketplace_product, class: 'Marketplace::Product' do | ||
| name { Faker::TvShows::DrWho.specie } |
There was a problem hiding this comment.
I wanted one that was more nerdy equipment but I can't always get what I want!
| end | ||
| end | ||
|
|
||
| # Appends each Furnitures CRUD actions within the {Room} |
There was a problem hiding this comment.
Nitpick: On the line below, is the routing_context actually just the router? That seems to be at least the variable name you are using in e.g. Marketplace.append_routes. router seems clearer to me than routing_context -- I don't know what the latter is.
| @@ -14,7 +14,15 @@ module Furniture | |||
| spotlight: Spotlight, | |||
| }.freeze | |||
|
|
|||
| # Appends each {Furniture}'s CRUD actions | |||
| # Appends each {Furniture}'s CRUD actions under a FurniturePlacement | |||
| # @deprecated | |||
app/furniture/marketplace.rb
Outdated
| Marketplace::Product.where(space: space) | ||
| end | ||
|
|
||
| def to_partial_path |
There was a problem hiding this comment.
Maybe add a comment that this implements https://apidock.com/rails/v6.1.3.1/ActiveModel/Conversion/to_partial_path , for clarity (I had to look up what was this doing, I wasn't familiar with this method, as I've never had the need to implement this myself).
| locals: { furniture: furniture_placement.furniture, space: furniture_placement.space, room: furniture_placement.room, | ||
| person: current_person } %> | ||
| <%- else %> | ||
| <%= render furniture_placement.furniture %> |
Rails assumes that your parameter names will match the namespace of the model. For example, a `Marketplace::Product#name` Rails will make HTTP Params of `marketplace_product[name]`, I had previously assumed it would name them `product[name]` because I thought it would discard the stuff before the `::`. Co-authored-by: Neer Thapa <nirmalathapa@users.noreply.github.com>
@anaulin had suggested that `routing_context` was confusing; and I agree. It's just the router! So let's name it that way! Co-authored-by: Neer Thapa <nirmalathapa@users.noreply.github.com>
Co-authored-by: Neer Thapa <nirmalathapa@users.noreply.github.com>
anaulin
added a commit
that referenced
this pull request
Oct 6, 2022
* Add scaffolding for new Marketplace furniture. Co-authored-by: Sadie Jay <19538219+sadiejay@users.noreply.github.com> Co-authored-by: Zee <zspencer@users.noreply.github.com> * Replace money gem with money-rails. Co-authored-by: Sadie <19538219+sadiejay@users.noreply.github.com> Co-authored-by: Zee <zspencer@users.noreply.github.com> * Add Marketplace::Products model, table (not Items!), form and controller. Co-authored-by: Sadie <19538219+sadiejay@users.noreply.github.com> Co-authored-by: Zee <zspencer@users.noreply.github.com> * Marketplace: Products Controller persists Products! (#856) This starts to shift our Furniture and Item system away from an inheritance oriented rails-adjacent structure to a more Rails-forward structure. Furniture now places it's routes against the *room*, which allows it to support either Singleton-type Resource routes, or more traditional Resources routes. Further, it brings the `Placeable` interface a bit closer to ActiveRecord; which should reduce pain-points as we unwind the current overly-restrictive and complex Furniture/Item design. * Marketplace: Products are shown! * Use correct parameter name in request spec Rails assumes that your parameter names will match the namespace of the model. For example, a `Marketplace::Product#name` Rails will make HTTP Params of `marketplace_product[name]`, I had previously assumed it would name them `product[name]` because I thought it would discard the stuff before the `::`. Co-authored-by: Neer Thapa <nirmalathapa@users.noreply.github.com> * Rename from `routing_context` to `router` @anaulin had suggested that `routing_context` was confusing; and I agree. It's just the router! So let's name it that way! Co-authored-by: Neer Thapa <nirmalathapa@users.noreply.github.com> * All `Placeable` now implement `to_partial_path` Co-authored-by: Neer Thapa <nirmalathapa@users.noreply.github.com> Co-authored-by: Zee Spencer <zspencer@users.noreply.github.com> Co-authored-by: Neer Thapa <nirmalathapa@users.noreply.github.com> * Fix method lookup in class ancestry Co-authored-by: Neer Thapa <nirmalathapa@users.noreply.github.com> * Marketplace: Present Products in a much cleaner way Co-authored-by: Neer Thapa <nirmalathapa@users.noreply.github.com> * Adds Button to add Products to Marketplace Co-authored-by: Neer Thapa <nirmalathapa@users.noreply.github.com> * Marketplace: Add Products to Product Table via TurboStreams This makes the user experience for adding a product even tighter; by hiding the Product form until the Distributor is adding a new product. Once they do, we replace the entire marketplace with the New Product form; and upon successful create, we replace the entire marketplace with the full Marketplace view! Co-authored-by: Neer Thapa <nirmalathapa@users.noreply.github.com> * Fixed test by redirecting to room rather than marketplace Still need to figure out how to redirect to furniture Co-authored-by: Kelly <KellyAH@users.noreply.github.com> Co-authored-by: Zee <zspencer@users.noreply.github.com> Co-authored-by: Ana <anaulin@users.noreply.github.com> * Marketplace: Validate product names Validate that `Marketplace::Product` belongs to a space Co-authored-by: Kelly <KellyAH@users.noreply.github.com> Co-authored-by: Zee <zspencer@users.noreply.github.com> Co-authored-by: Ana <anaulin@users.noreply.github.com> Co-authored-by: Sadie Jay <19538219+sadiejay@users.noreply.github.com> Co-authored-by: Zee <zspencer@users.noreply.github.com> Co-authored-by: Zee <50284+zspencer@users.noreply.github.com> Co-authored-by: Neer Thapa <nirmalathapa@users.noreply.github.com> Co-authored-by: Kelly <KellyAH@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts to shift our Furniture and Item system away from an inheritance oriented rails-adjacent structure to a more Rails-forward structure.
Furniture now places it's routes against the room, which allows it to support either Singleton-type Resource routes, or more traditional Resources routes.
Further, it brings the
Placeableinterface a bit closer to ActiveRecord; which should reduce pain-points as we unwind the current overly-restrictive and complex Furniture/Item design.