Workspaces may be entered via Branded Domain #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccd60bf to
948ceb1
Compare
user512
reviewed
Aug 3, 2020
convene-web/db/seeds.rb
Outdated
|
|
||
| ada = zincs_workspace.rooms.create(name: 'Ada', access_level: :unlocked, publicity_level: :listed) | ||
| ttz = zincs_workspace.rooms.create(name: 'Talk to Zee', access_level: :unlocked, publicity_level: :unlisted) | ||
| ada = zincs_workspace.rooms.find_or_create_by!(name: 'Ada' |
There was a problem hiding this comment.
Suggested change
| ada = zincs_workspace.rooms.find_or_create_by!(name: 'Ada' | |
| ada = zincs_workspace.rooms.find_or_create_by!(name: 'Ada') |
user512
reviewed
Aug 3, 2020
| @@ -4,6 +4,9 @@ class Workspace < ApplicationRecord | |||
| # Which client owns the workspace | |||
| belongs_to :client | |||
|
|
|||
| # The fully-qualified domain to enter the workspace | |||
| attribute :branded_domain, :string | |||
There was a problem hiding this comment.
Do we need to add some unique constraint/ validation on branded_domain?
There was a problem hiding this comment.
Good point! I've added a uniquness validation.
See: #61 Branded Domains allow Visitors to bypass hitting the `/workspaces/:slug` path and drop them right in the Workspaces Lobby. For example, `convene-demo.zinc.coop` is a branded domain for the `Convene Demo` workspace. `meet.zinc.coop` is a branded domain for the Zinc workspace.
Probably should think a bit more about this...
4835ff1 to
65414b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #61, #61
Branded Domains allow Visitors to bypass hitting the
/workspaces/:slugpath and drop them right in the Workspaces Lobby.
For example,
convene-demo.zinc.coopis a branded domain for theConvene Demoworkspace.meet.zinc.coopis a branded domain for theZinc workspace.