🌸✨ Marketplace: Checkout includes Products, Taxes, and DeliveryFee
#1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marketplace: Checkout includes Products, Taxes, and DeliveryFeeMarketplace: Checkout includes Products, Taxes, and DeliveryFee
rosschapman
reviewed
Dec 5, 2023
| <h3 class="font-bold">Delivering to:</h3> | ||
| <p> | ||
| <%= render(delivery.delivery_area) %><br /> | ||
| <span class="text-sm font-light italic"><%= render(Marketplace::Cart::DeliveryExpectationsComponent.new(cart: delivery.cart)) %></span> |
There was a problem hiding this comment.
Could this text styling become part of the component? Layout styling makes sense for wrapper tags but if these seem like inherent styling attributes of the component itself not of this "area" of the page.
There was a problem hiding this comment.
Sure, I think pushing this responsibility down is a good idea
There was a problem hiding this comment.
Ehh, actually let's not do that just yet. DeliveryExpectationsComponent is rendered in a number of places, with a substantially different information hierarchy.
Presuming it should always be small, light, and italic does not seem to be valid.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marketplace: Buying 🥡Products#1326It's not the prettiest, but it includes each product being purchased,
the quantity, the unit pricer, and the total price as well as the taxes
and delivery fees.