🧹 Section: Remove Navigation in favor of SectionNavigation Gizmo
#1989
Conversation
|
I've gotten rid of the feature tests that cover the presumption that Sections will always have a navigation element. I took the time to use |
Now that we're using the gizmo, it doesn't make sense to have end-to-end tests that presume every Section will include functioality to navigate between Sections. This also gets rid of all the unused step definitions.
40cd2c1 to
8209187
Compare
33fe75b to
4c0b8ec
Compare
| data: { access_level: room.access_level, slug: room.slug, model: "room", id: room.id }, | ||
| classes: "group self-stretch hover:bg-orange-50" | ||
| ) do %> | ||
| <%= link_to polymorphic_path(room.location), class: "no-underline" do %> |
There was a problem hiding this comment.
I'm not sure why, but link_to is including the full url; which I think is related to our over-loading of url_for.
I didn't want to get into it; but it's annoying.
There was a problem hiding this comment.
I'm curious why use a system spec vs a view spec to test rendered content?
There was a problem hiding this comment.
This doesn't have a ViewComponent yet and I was doing a lot of other cleanup so I didn't want to add that change too.
Also since I was deleting System specs it felt better to create new system specs. A ViewComponent spec would definitely be a better call when we get to more permutations.
There was a problem hiding this comment.
Is there a RoR convention (informal | formal) that a "view spec" must be backed by a ViewComponent? Or this is a Convene worldview?
There was a problem hiding this comment.
I'm not aware of there being such a convention in neither RoR at large nor Convene specifically.
That said, I personally don't see the point of view specs, and would much rather do that kind of testing either in smaller component specs, or as part of larger integration/system tests (depending on the level of granularity desired). A view spec to me feels like "testing HTML", which smells funky.
YMMV YDY YOLO
There was a problem hiding this comment.
Yea, I tend to not write Rails view specs because once they get to the point of complexity that I would want one, I wrap it into a ViewComponent.
Or like Ana said, I test it in a request or system spec until it gets ungainly.
Sections#1155Gizmo:SectionNavigation#1988Now that we have a Gizmo for navigating between Sections, we don't want to keep it everywhere.