🧹 Marketplace: Cache the fee amount on the Order
#1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- #1327 In order to pull the splitting of the payment to a retriable background job; we need to cache the payment processor fee information.
|
See #1702 for the usage of this cached value |
anaulin
approved these changes
Jul 26, 2023
| def vendors_share | ||
| product_total - payment_processor_fee | ||
| end | ||
|
|
There was a problem hiding this comment.
Should product_total be monetized as well? It seems odd to be substracting two values, one of which is monetized and the other one isn't.
There was a problem hiding this comment.
product_total is monetized, in that it sums the monetized product_price * quantity
| @@ -21,7 +21,7 @@ def create | |||
| latest_charge = Stripe::Charge.retrieve(payment_intent.latest_charge, api_key: marketplace.stripe_api_key) | |||
| balance_transaction = Stripe::BalanceTransaction.retrieve(latest_charge.balance_transaction, api_key: marketplace.stripe_api_key) | |||
|
|
|||
| order.update(status: :paid, placed_at: DateTime.now) | |||
| order.update(status: :paid, placed_at: DateTime.now, payment_processor_fee_cents: balance_transaction.fee) | |||
There was a problem hiding this comment.
Not from this PR, but I'm noticing that we do this .update and don't seem to be checking for success, opening us up to the possibility that this update will fail, the order won't be marked as paid, but notifications and other parts of the "order pipeline" would continue as if everything was fine.
One quick fix would be to throw a ! onto the order.update call.
zspencer
added a commit
that referenced
this pull request
Jul 28, 2023
… `paid` - Recommended by @anaulin #1701 (comment)
zspencer
added a commit
that referenced
this pull request
Aug 3, 2023
… `paid` (#1717) - Recommended by @anaulin #1701 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marketplace:SplitPaymentbetweenVendorandDistributor#1327In order to pull the splitting of the payment to a retriable background job; we need to cache the payment processor fee information.