Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🥗🔨🐞 Neighborhood: Footer links to the Neighborhood URL #1519

Merged
merged 1 commit into from
Jun 1, 2023
Merged

🥗🔨🐞 Neighborhood: Footer links to the Neighborhood URL #1519

merged 1 commit into from
Jun 1, 2023

Conversation

zspencer
Copy link
Member

I noticed that the Convene link in the footer was always to the current root_url, which will be the Space when visiting the Space via a Domain.

This shifts it to use the APP_ROOT_URL, and allows Operators to configure the Neighborhood name and Tagline.

@zspencer zspencer added the 🐞 bug Something isn't working label May 27, 2023
@zspencer zspencer requested a review from a team May 27, 2023 03:33
@zspencer zspencer force-pushed the neighborhood/operator-may-set-neighborhood-tagline branch from da81acd to 3c3b9ca Compare May 27, 2023 03:40
@zspencer zspencer changed the title 🐞 Neighborhood: Footer always links to the Neighborhood URL. 🔨🐞 Neighborhood: Footer always links to the Neighborhood URL. May 27, 2023
@zspencer zspencer added 🥗 test automation Adds some automated tests. V nutritious. 🔨 Squashed Bugs we think we fixed labels May 27, 2023
@zspencer zspencer changed the title 🔨🐞 Neighborhood: Footer always links to the Neighborhood URL. 🥗🔨🐞 Neighborhood: Footer always links to the Neighborhood URL. May 27, 2023
@zspencer zspencer force-pushed the neighborhood/operator-may-set-neighborhood-tagline branch from 3c3b9ca to 2975ba8 Compare May 27, 2023 03:54
@zspencer
Copy link
Member Author

If you, like me, would prefer to not forget to run the linter before committing; you can write a git pre-commit hook like so:

echo "bin/lint-changed" > .git/hooks/pre-commit && chmod +x .git/hooks/pre-commit

@zspencer zspencer changed the title 🥗🔨🐞 Neighborhood: Footer always links to the Neighborhood URL. 🥗🔨🐞 Neighborhood: Footer links to the Neighborhood URL May 28, 2023
@zspencer
🐞 Neighborhood: Link explicitly to the Neighborhood URL.
2561c42 
- #892
- #74

I noticed that the `Convene` link in the footer was always to the
current `root_url`, which will be the `Space` when visiting the `Space`
via a `Domain`.

This shifts it to use the `APP_ROOT_URL`, and allows `Operator`s to
configure the Neighborhood name and Tagline.
@zspencer zspencer force-pushed the neighborhood/operator-may-set-neighborhood-tagline branch from 2975ba8 to 2561c42 Compare June 1, 2023 00:25
@zspencer zspencer merged commit f92ec49 into main Jun 1, 2023
@zspencer zspencer deleted the neighborhood/operator-may-set-neighborhood-tagline branch June 1, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonrpruitt daltonrpruitt daltonrpruitt approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working 🔨 Squashed Bugs we think we fixed 🥗 test automation Adds some automated tests. V nutritious.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zspencer @daltonrpruitt