Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🥗🐞 Marketplace: Don't explode on Checkout #1434

Merged
merged 1 commit into from
May 4, 2023

Conversation

zspencer
Copy link
Member

@zspencer zspencer commented May 4, 2023

This is wildly insufficient, but it gets us to the point where we're able to test that the way we're calling Stripe::Checkout::Session.create is at least close to what it's supposed to be called with.

It would be far better to get a spec/furniture/marketplace/system that actually hits Stripe...

- #1326
- #1324

This is wildly insufficient, but it gets us to the point where we're
able to test that the way we're calling `Stripe::Checkout::Session.create`
is at least *close* to what it's supposed to be called with.

It would be far better to get a `spec/furniture/marketplace/system` that
actually hits Stripe...
@zspencer zspencer requested a review from a team May 4, 2023 02:44
@zspencer zspencer changed the title Marketplace: Get a test on the Checkout 🐞 Marketplace: Don't explode on Checkout May 4, 2023
@zspencer zspencer added 🐞 bug Something isn't working 🥗 test automation Adds some automated tests. V nutritious. labels May 4, 2023
@zspencer zspencer merged commit 2b01de8 into main May 4, 2023
@zspencer zspencer deleted the marketplace/better-tests-for-checkout-flow branch May 4, 2023 02:57
@zspencer zspencer changed the title 🐞 Marketplace: Don't explode on Checkout 🥗🐞 Marketplace: Don't explode on Checkout May 6, 2023
@zspencer zspencer added this to the 1.0 - Andromeda milestone May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🥗 test automation Adds some automated tests. V nutritious.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants