🥗🥔✨ Marketplace: Show DeliveryArea's #order_by and #delivery_window
#1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indow` - #1185 We added some tests to the `DeliveryAreaComponent` to make sure it looks reasonable in each use-case: - `#delivery_window` with no data - `#delivery window` with a string - `#order_by` with no data - `#order_by` with a string We also included "by" in the `_window.html.erb` partial so that people don't have to write it in their `order_by`. Co-authored-by: Neer Malathapa <nirmalathapa@users.noreply.github.com> Co-authored-by: Dicko Sow <s12dsow@users.noreply.github.com>
anaulin
approved these changes
Apr 16, 2023
9023c14
into
marketplace/delivery-area/add-order-by-and-delivery-window
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marketplace:DeliveryConstraints #1185We added some tests to the
DeliveryAreaComponentto make sure it looks reasonable in each use-case:#delivery_windowwith no data#delivery windowwith a string#order_bywith no data#order_bywith a stringWe also included "by" in the
_window.html.erbpartial so that people don't have to write it in theirorder_by.