Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔐 Marketplace: Step 2 of Lockbox migration #1175

Merged
merged 4 commits into from
Mar 3, 2023

Conversation

zspencer
Copy link
Member

@zspencer zspencer commented Mar 3, 2023

zspencer added 3 commits March 3, 2023 12:09
- #1136
- #831

So, I totally didn't think about how delivery addresses are PII and
probably should not be stored in plaintext! Womp. Womp. Womp.

Now they ain't!

We'll want to delete the `release:after_build` bits after a prod deploy.
- #831
- #1136

Merge and deploy immediately after #1169
@zspencer zspencer requested a review from KellyAH March 3, 2023 20:19
zspencer added a commit that referenced this pull request Mar 3, 2023
@zspencer zspencer marked this pull request as ready for review March 3, 2023 20:31
Base automatically changed from marketplace/collect-delivery-address-on-cart to main March 3, 2023 20:31
@zspencer zspencer merged commit 92ba5ed into main Mar 3, 2023
@zspencer zspencer deleted the marketplace/step-2-of-migrating-data branch March 3, 2023 20:38
zspencer added a commit that referenced this pull request Mar 3, 2023
zspencer added a commit that referenced this pull request Mar 3, 2023
@zspencer zspencer added 🔐 security Relates to security vulnerabilities 🧹 refactor Includes non-behavioral changes and removed 🧹 refactor Includes non-behavioral changes labels Mar 3, 2023
@zspencer zspencer added this to the 1.0 - Andromeda milestone May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 security Relates to security vulnerabilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant