Memberships: Invitations work on BYO Domains #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like all Resources in Convene, Invitations to a Convene Space can be on a BYO Domain *or* a path under the Neighborhoods primary domain, they want to use the `location` method for determining where they live within the object graph.
anaulin
approved these changes
Jan 31, 2023
|
Yea, I have a WIP PR trying to swat the bugs and would love for someone to figure out how we could run our end-to-end tests against a BYO-domain space! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1078
#117
#74
There's probably a bunch of other domain objects that want
parent_locationset; but this should be good enough to get the invitations flow unbroken.