Space: BYO Domains drop Space from polymorphic_urls #1000
Conversation
#74 This had been bugging me for a bit, where the paths on the page would always include the spaces, even if they were being routed to a custom domain. Now, we send folks to the domain that the space claims and drop the Space from the path, but only on urls built using Rails Polymorphic url builders. For example: `space_room_path(space, room)` will still go to `current_domain.example.com/spaces/:space_id/rooms/:room_id`, while `url_for([space, room])` or `link_to([space, room])` will go to `space_domain.example.com/rooms/:room_id`
Move (almost) everything to the Polymorphic syntax!
| options | ||
| end | ||
|
|
||
| if space |
There was a problem hiding this comment.
You could return early unless space.present?, I think it would be a tad more readable
There was a problem hiding this comment.
I think I need to return super unless space but ya!
| @@ -27,6 +27,38 @@ class ApplicationController < ActionController::Base | |||
|
|
|||
| helper_method :current_person | |||
|
|
|||
| helper_method def url_for(options) | |||
There was a problem hiding this comment.
These two methods are arcane enough that I think they warrant at least a one-sentence comment explaining that they augment the standard Rails helpers to make URLs on branded domains nicer.
There was a problem hiding this comment.
Good call, I've linked to the core docs and included a sentance.
| options.delete_at(0) | ||
| elsif [:edit, :new].include?(options[0]) && options[1].is_a?(Space) && options[1].branded_domain.present? | ||
| options.delete_at(1) | ||
| elsif options.is_a?(Space) && options.branded_domain.present? |
There was a problem hiding this comment.
Not sure if it is worth it, or if it would make the code even harder to understand, but these checks for "is this a Space and does it have a branded domain" could be tightened up like:
thing_were_checking.try(:branded_domain).present?Which is a little bit more flexible (will work for any object that has a branded_domain, even if it is not a Space), but I think works for our purposes.
There was a problem hiding this comment.
I always forget about .try(:foo)!
#74
This had been bugging me for a bit, where the paths on the page would always include the spaces, even if they were being routed to a custom domain.
Now, we send folks to the domain that the space claims and drop the Space from the path, but only on urls built using Rails Polymorphic url builders.
For example:
space_room_path(space, room)will still go tocurrent_domain.example.com/spaces/:space_id/rooms/:room_id, whileurl_for([space, room])orlink_to([space, room])will go tospace_domain.example.com/rooms/:room_id