Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen Sharing #91

Closed
2 of 6 tasks
zspencer opened this issue Aug 15, 2020 · 0 comments
Closed
2 of 6 tasks

Screen Sharing #91

zspencer opened this issue Aug 15, 2020 · 0 comments
Labels
⛰️ epic Work we expect will take multiple patches to complete ✨ feature Reduces Client's Burden or Grants them Benefits
Milestone

Comments

@zspencer
Copy link
Member

zspencer commented Aug 15, 2020

This Issue May Be Closed When

  • When screen sharing, the video portal fills the entire display
  • When screen sharing ends, the video panel shrinks
  • The feature definition is added to source control
  • The feature definition’s steps are wired in
  • The Release Notes include the screen sharing feature
  • There is a written guide to using screen sharing

Feature Definition

Feature: Screen Sharing
  In order to show what we’re working on
  I want to be able to share my screen with a Room

  Scenario: Beginning Screen Sharing
    Given I am in in a Video Room
    When Screen Sharing begins
    Then I can see the shared screen 
    And the Video fills entire screen width and height
    And I can scroll past the Video to get to the other Room elements

Implementation Details

The Jitsi iFrame API does have a screenSharingStatusChanged event0, which we can use to set the width and height attributes on the iFrame to 100vh and 100vw1 respectively; thus ensuring that screen fills the entire browser screen.

We should be able to listen to this event in video_room.js and swap classes on the containing element. Perhaps adding a class like screen-sharing--active to the iFrame itself?

@zspencer zspencer added code ✨ feature Reduces Client's Burden or Grants them Benefits ⛰️ epic Work we expect will take multiple patches to complete labels Aug 15, 2020
@zspencer zspencer added this to the 1.0 - Andromeda milestone Aug 15, 2020
zspencer pushed a commit that referenced this issue Aug 21, 2020
See: #91

I thought about adding some text at the bottom of the iframe but then
it was really hard to make it sync with the show timing of the jitsi default button (hangup/ mute).
zspencer added a commit that referenced this issue Aug 21, 2020
See: #91

Thanks to @user512, video panels fill the entire view portal, which makes it easier to 
see what is going on when screen sharing.
zspencer added a commit that referenced this issue Aug 21, 2020
See: #91

Thanks to @user512, video panels fill the entire view portal, which makes it easier to 
see what is going on when screen sharing.
user512 pushed a commit that referenced this issue Aug 21, 2020
See: #91

Thanks to @user512, video panels fill the entire view portal, which makes it easier to 
see what is going on when screen sharing.
@zspencer zspencer added test and removed code labels Sep 11, 2020
@zspencer zspencer modified the milestones: 1.0 - Andromeda, 1.1 - B? Feb 4, 2021
@zspencer zspencer closed this as completed Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛰️ epic Work we expect will take multiple patches to complete ✨ feature Reduces Client's Burden or Grants them Benefits
Projects
None yet
Development

No branches or pull requests

1 participant