[milvus-4.1.18] Enabling High Availability for Milvus

[Rachit-Chaudhary11]

What this PR does / why we need it:

By enabling this feature, Milvus Instances will be resilient to failures, ensuring continuous availability and reliability for users. The implementation includes fault-tolerant mechanisms and redundancy configurations to mitigate downtime and main uninterrupted service in the event of node failures or network issues. Overall, this enhancement enhances the robustness and performance of Milvus, providing a more resilient infrastructure for data storage and retrieval.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• Chart Version bumped
• Variables are documented in the README.md
• Title of the PR starts with chart name (e.g. [mychartname])
• PR only contains changes for one chart

[haorenfsa]

context: #67

[haorenfsa]

Hi @Rachit-Chaudhary11, a little advice, better continue the work on the same PR, so that we could tract the context of the problem directly.

For example, your previous work is on branch rollingupgrade, then you refine it on the branch deploymentStrategy.
So after you finish your work, you can checkout rollingupgrade again, and git reset deploymentStrategy --hard to make this branch the same as deploymentStrategy. Then you can use git push origin rollingupgrade -f to force update your rollingupgrade branch on github.
In this way, we can now continue the progress on the previous PR opened with branch rollingupgrade.

[haorenfsa]

/lgtm

[haorenfsa]

/cc @LoveEachDay please help review

[sre-ci-robot]

@haorenfsa: GitHub didn't allow me to request PR reviews from the following users: review, please.

Note that only zilliztech members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @LoveEachDay please help review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Rachit-Chaudhary11]

Hi @Rachit-Chaudhary11, a little advice, better continue the work on the same PR, so that we could tract the context of the problem directly.

@haorenfsa
I have done this to keep the alternative approaches in separate branches as the other approach we are planning to use for an older version. I will still keep this in mind. Thanks.

[LoveEachDay]

@Rachit-Chaudhary11 Only if we have enabled activeStandby for milvus coordinator components, we can use rollingUpdate strategy, otherwise the pod will crash when rolling update.

Could you also check whether rootCoordinator.avtiveStandby.enabled is true before change the deployment strategy?

[Rachit-Chaudhary11]

@LoveEachDay Thank you for the suggestion. I have made the necessary changes, kindly validate.
cc: @haorenfsa

[Rachit-Chaudhary11]

This is a needed check to avoid any wrong replicas value to be inserted.

[haorenfsa]

/lgtm

[sre-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Rachit-Chaudhary11

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[haorenfsa]

@Rachit-Chaudhary11 Looks good. Thank you for the contribution!