infer orelse on a C-pointer as a C-pointer

zigtools · Feb 8, 2025 · b733071 · b733071
1 parent c8bd727
commit b733071
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/src/analysis.zig b/src/analysis.zig
@@ -865,6 +865,10 @@ pub fn resolveOptionalUnwrap(analyser: *Analyser, optional: Type) error{OutOfMem
             std.debug.assert(child_ty.is_type_val);
             return try child_ty.instanceTypeVal(analyser);
         },
+        .pointer => |ptr| {
+            if (ptr.size == .c) return optional;
+            return null;
+        },
         else => return null,
     }
 }

diff --git a/tests/lsp_features/hover.zig b/tests/lsp_features/hover.zig
@@ -1164,6 +1164,19 @@ test "optional" {
         \\(i32)
         \\```
     );
+
+    try testHover(
+        \\var value: u32 = 123;
+        \\const ptr: [*c]u32 = &value;
+        \\const f<cursor>oo = ptr orelse unreachable;
+    ,
+        \\```zig
+        \\const foo = ptr orelse unreachable
+        \\```
+        \\```zig
+        \\([*c]u32)
+        \\```
+    );
 }
 
 test "error union" {