Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap Direction enum #2965

Merged
merged 2 commits into from
Feb 4, 2024
Merged

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Feb 4, 2024

Proposed change

Fixes quirks to account for zigpy/zigpy#1331. The direction enum's values were flipped. This corrects their use in quirks.

I didn't notice any quirks in PRs that used this enum so I think this change will not break anything even for custom quirk users.

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97d2734) 87.68% compared to head (5fd083c) 87.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2965   +/-   ##
=======================================
  Coverage   87.68%   87.68%           
=======================================
  Files         297      297           
  Lines        9084     9084           
=======================================
  Hits         7965     7965           
  Misses       1119     1119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES merged commit 1f29b72 into zigpy:dev Feb 4, 2024
15 checks passed
lgraf pushed a commit to lgraf/zha-device-handlers that referenced this pull request May 6, 2024
* Invert use of `Server_to_Client` and `Client_to_Server`

* Bump minimum zigpy version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants