-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementations for NO_MANUFACTURER_ID
dimmers
#1489
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1489 +/- ##
==========================================
+ Coverage 80.36% 80.40% +0.03%
==========================================
Files 227 227
Lines 6702 6725 +23
==========================================
+ Hits 5386 5407 +21
- Misses 1316 1318 +2
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 2163027951
💛 - Coveralls |
Hey, I recently had my device support request closed via this thread. I assume a fix has been implemented? Any work I need to do to add the fix or will an update to ZHA via Homeassistant fix this. Thank you so much for your work! |
Hi @yftj, However, there is no simple criteria to define when the new version of the library will be generated or when it will be included in HA, it depends on multiple factors. |
Just tested today with the new update to HAOS, I have full control of my dimmers now (dimmer switch TS0601 _TZE200_1agwnems)! Thank you very much! There is however a small problem, changing the brightness slider causes the light to momentarily turn off almost like a reset for a fraction of a second (time it takes to blink almost) and then from full brightness goes down to the selected brightness. Expected result would be for the dimmer to change from eg. 40% to 50% instead it goes from 40% to off to 100% and slowly dims to 50%. Sorry if this isn't the right place to report a bug. |
@yftj Please, open a new issue with your device info and attach the logs from your problem. The logs will tell us if the behaviour comes from HA, from ZHA or if is a device issue. |
Implement the `on_off` call in the `move_to_level_with_on_off` command for the MCU Tuya devices. The previous implementation was removed in zigpy#1748. Originally introduced in zigpy#1489
This PR adds device definitions for dimmers that require send commands with the
NO_MANUFACTURER_ID
(or what is the samemanufacturer_specific=False
).A few comments:
tuya/mcu/TuyaLevelControl
now handlesmove_to_level_with_on_off
command, sending anon_off
command before thecurrent_level
command.TuyaLevelControlManufCluster
handles DPs up to 3 gangs.NoManufacturerCluster
will force theNO_MANUFACTURER_ID
in commands. This is needed for recent dimmersTuyaSingleSwitchDimmer
devices will use the same implementation as the restNoManufacturerCluster
implementation and others no. It can be important (or not) when adding new devices to the existing implementationsRelated issues:
This PR is good to go in next minor version.