-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TS0601 Dimmer gpp #1122
TS0601 Dimmer gpp #1122
Conversation
Adding GP EP and "_TZE200_3p5ydos3"
Codecov Report
@@ Coverage Diff @@
## dev #1122 +/- ##
==========================================
+ Coverage 80.01% 80.02% +0.01%
==========================================
Files 197 197
Lines 5403 5406 +3
==========================================
+ Hits 4323 4326 +3
Misses 1080 1080
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 1425647254
💛 - Coveralls |
@MattWestb Are you still working on this? Is there any progress? |
Not my but one very good user is working on tuya Dp dimmers and is reworking large things for getting it working OK #1247. I was only making this for getting the first gang working for user that liking getting some function but is never going in and i deleting it the the new quirk is working and is being merged. |
@MattWestb Thanks^^ I dont understand it completely because I'm pretty new in this field, but when will this be available/how long does it take that it gets to ZHA? |
LevelControl.cluster_id, | ||
TuyaManufacturerClusterOnOff, | ||
TuyaOnOff, | ||
TuyaManufacturerLevelControl, | ||
TuyaLevelControl, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one manufacturer cluster for receiving commands and the TuyaOnOff
and TuyaLevelControl
to simulate the ZB function (TuyaLevelControl
replaces the LevelControl
).
Replace with:
TuyaManufacturerLevelControl,
TuyaOnOff,
TuyaLevelControl,
# "node_descriptor": "<NodeDescriptor byte1=1, byte2=64, mac_capability_flags=142, manufacturer_code=4098, | ||
# maximum_buffer_size=82, maximum_incoming_transfer_size=82, server_mask=11264, | ||
# maximum_outgoing_transfer_size=82, descriptor_capability_field=0>", | ||
# <SimpleDescriptor endpoint=1 profile=260 device_type=51 device_version=1 input_clusters=[0, 4, 5, 61184] output_clusters=[10, 25]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The descriptor is not correct. I think it is better to remove it.
Thanks for comments @javicalle but i cant testing the device and the original user was not interested so i was "leaving it as WIP" for user can downloading it and getting the first gang working. Mvh Mattias |
Use the linked issues for implanting new devices with the new approach linked abow. |
Adding GPP cluster and device "_TZE200_3p5ydos3".
Is getting status from the device but cant controlling it from ZHA.
Making is as draft so user can using it if they like but dont like merging in ZHA until it have more core function working.
Fixes #1103