Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS0601 Dimmer gpp #1122

Closed
wants to merge 3 commits into from
Closed

TS0601 Dimmer gpp #1122

wants to merge 3 commits into from

Conversation

MattWestb
Copy link
Contributor

Adding GPP cluster and device "_TZE200_3p5ydos3".
Is getting status from the device but cant controlling it from ZHA.

Making is as draft so user can using it if they like but dont like merging in ZHA until it have more core function working.

Fixes #1103

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #1122 (2108264) into dev (ba8048a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1122      +/-   ##
==========================================
+ Coverage   80.01%   80.02%   +0.01%     
==========================================
  Files         197      197              
  Lines        5403     5406       +3     
==========================================
+ Hits         4323     4326       +3     
  Misses       1080     1080              
Impacted Files Coverage Δ
zhaquirks/tuya/ts0601_dimmer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba8048a...2108264. Read the comment docs.

@coveralls
Copy link

coveralls commented Nov 2, 2021

Pull Request Test Coverage Report for Build 1425647254

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 80.022%

Totals Coverage Status
Change from base Build 1422163943: 0.01%
Covered Lines: 4326
Relevant Lines: 5406

💛 - Coveralls

@Tropaion
Copy link
Contributor

@MattWestb Are you still working on this? Is there any progress?
I bought this and didn't know it isn't supported currently.

@MattWestb
Copy link
Contributor Author

Not my but one very good user is working on tuya Dp dimmers and is reworking large things for getting it working OK #1247.
If you like try it out the work is don (not all os working but the ground is ther) look in #1033.

I was only making this for getting the first gang working for user that liking getting some function but is never going in and i deleting it the the new quirk is working and is being merged.

@Tropaion
Copy link
Contributor

@MattWestb Thanks^^ I dont understand it completely because I'm pretty new in this field, but when will this be available/how long does it take that it gets to ZHA?

Comment on lines +126 to +130
LevelControl.cluster_id,
TuyaManufacturerClusterOnOff,
TuyaOnOff,
TuyaManufacturerLevelControl,
TuyaLevelControl,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one manufacturer cluster for receiving commands and the TuyaOnOff and TuyaLevelControl to simulate the ZB function (TuyaLevelControl replaces the LevelControl).

Replace with:

                    TuyaManufacturerLevelControl,
                    TuyaOnOff,
                    TuyaLevelControl,

Comment on lines +87 to +90
# "node_descriptor": "<NodeDescriptor byte1=1, byte2=64, mac_capability_flags=142, manufacturer_code=4098,
# maximum_buffer_size=82, maximum_incoming_transfer_size=82, server_mask=11264,
# maximum_outgoing_transfer_size=82, descriptor_capability_field=0>",
# <SimpleDescriptor endpoint=1 profile=260 device_type=51 device_version=1 input_clusters=[0, 4, 5, 61184] output_clusters=[10, 25]>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The descriptor is not correct. I think it is better to remove it.

@MattWestb
Copy link
Contributor Author

Thanks for comments @javicalle but i cant testing the device and the original user was not interested so i was "leaving it as WIP" for user can downloading it and getting the first gang working.
I think its better you is integrating this device in your work and can testing it with interested users.

Mvh Mattias

@MattWestb
Copy link
Contributor Author

Use the linked issues for implanting new devices with the new approach linked abow.

@MattWestb MattWestb closed this Jan 25, 2022
@MattWestb MattWestb deleted the Dimmer-GP branch February 15, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Device Support Request] Support for Tuya TS0601 dimmer
5 participants