Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blocking metadata version call #630

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

TheJulianJES
Copy link
Contributor

This moves the blocking metadata version call outside of the load_network_info coroutine that's run at startup.
I'll do this for the other radio libraries too, just want to confirm if we want to have that constant named LIB_VERSION, just VERSION, PACKAGE_VERSION, or BELLOWS_VERSION?

The test still blocks when checking it, but that should be fine.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.72%. Comparing base (09cf7ce) to head (6e051af).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #630   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files          75       75           
  Lines        5002     5003    +1     
=======================================
+ Hits         4988     4989    +1     
  Misses         14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puddly
Copy link
Contributor

puddly commented Jun 14, 2024

I think I've only ever seen top_level_module.__version__. Putting it in module.application.zigbee.LIB_VERSION makes it pretty much library-internal.

@TheJulianJES
Copy link
Contributor Author

I think I've only ever seen top_level_module.__version__. Putting it in module.application.zigbee.LIB_VERSION makes it pretty much library-internal.

Yeah, I don't expect anyone else to use this. This is just to fix the blocking call.
I just used LIB_VERSION as the name, so it's clear that we don't access the EZSP version or whatever.
Or do you want something else?

@puddly
Copy link
Contributor

puddly commented Jun 14, 2024

Nope, it's all good the way it is. Thanks!

@puddly puddly merged commit 3875d11 into zigpy:dev Jun 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants