-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PKI API compatibility #613
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abdulbois <abdulbois.tursunov@dsr-corporation.com> Signed-off-by: Abdulbois <abdulbois123@gmail.com> Signed-off-by: Abdulbois Tursunov <abdulbois.tursunov@dsr-corporation.com>
b819dcb
to
58f05ee
Compare
58f05ee
to
1493f18
Compare
6e01c7c
to
8372855
Compare
8372855
to
0f73476
Compare
Artemkaaas
commented
Nov 5, 2024
86c7f69
to
fbf4f84
Compare
01d39d1
to
85e8358
Compare
ashcherbakov
reviewed
Nov 6, 2024
9d76e2f
to
e52510b
Compare
e52510b
to
c2f831b
Compare
ec64cd6
to
2ef3fe9
Compare
proto/zigbeealliance/distributedcomplianceledger/pki/all_certificates_by_subject.proto
Show resolved
Hide resolved
f4e27a1
to
2916f4c
Compare
ashcherbakov
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is address to resolve the following issues connected to PKI API compatibility:
Changes:
CertificateType
enum instead ofisNoc
boolean flag/dcl/pki/all-certificates
/dcl/pki/all-certificates/{subject}/{subjectKeyId}
/dcl/pki/child-certificates/{issuer}/{authorityKeyId}
/dcl/pki/certificates
/dcl/pki/certificates/{subject}
/dcl/pki/certificates/{subject}/{subjectKeyId}
/dcl/pki/revoked-certificates/{subject}/{subjectKeyId}
/dcl/pki/revoked-certificates
/dcl/pki/root-certificates
/dcl/pki/revoked-root-certificates
/dcl/pki/all-noc-certificates
/dcl/pki/all-noc-certificates/{subject}
/dcl/pki/all-noc-certificates/{subject}/{subjectKeyId}
/dcl/pki/noc-certificates/{vid}/{subjectKeyId}
/dcl/pki/noc-root-certificates/{vid}
/dcl/pki/noc-root-certificates
/dcl/pki/noc-ica-certificates/{vid}
/dcl/pki/noc-ica-certificates
/dcl/pki/revoked-noc-root-certificates/{subject}/{subjectKeyId}
/dcl/pki/revoked-noc-root-certificates
/dcl/pki/revoked-noc-ica-certificates/{subject}/{subjectKeyId}
/dcl/pki/revoked-noc-ica-certificates