Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: customisable task entrypoint #86

Merged
merged 6 commits into from
Jul 21, 2023
Merged

feat: customisable task entrypoint #86

merged 6 commits into from
Jul 21, 2023

Conversation

0xdeadbad
Copy link
Contributor

Pull request for Add ability to customise the entrypoint #22

zifeo
zifeo requested changes Jul 18, 2023
View reviewed changes
Copy link
Owner

@zifeo zifeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contrib, two comments before we move forward.

src/actors/command.rs Outdated Show resolved Hide resolved
src/actors/command.rs Outdated Show resolved Hide resolved
zifeo
zifeo reviewed Jul 20, 2023
View reviewed changes
Copy link
Owner

@zifeo zifeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, one little suggestion

src/actors/command.rs Outdated Show resolved Hide resolved
@0xdeadbad 0xdeadbad changed the title Feature entrypoint per task feat: customisable task entrypoint Jul 21, 2023
zifeo
zifeo approved these changes Jul 21, 2023
View reviewed changes
Copy link
Owner

@zifeo zifeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@zifeo zifeo merged commit eb25938 into zifeo:main Jul 21, 2023
@0xdeadbad 0xdeadbad deleted the entrypoint_feature branch July 25, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zifeo zifeo zifeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xdeadbad @zifeo