Fixed dahall#488 that ShellFolder.EnumerateChildIds might throw NullR…

…eferenceException if failed to enum the objects
zhuxb711 · Jan 2, 2025 · 2b47a09 · 2b47a09
1 parent 7c18a56
commit 2b47a09
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/Windows.Shell.Common/ShellObjects/ShellFolder.cs b/Windows.Shell.Common/ShellObjects/ShellFolder.cs
@@ -204,7 +204,11 @@ public IEnumerable<ShellItem> EnumerateChildren(FolderItemFilter filter /*= Fold
 	public IEnumerable<PIDL> EnumerateChildIds(FolderItemFilter filter /*= FolderItemFilter.Folders | FolderItemFilter.IncludeHidden | FolderItemFilter.NonFolders | FolderItemFilter.IncludeSuperHidden */, HWND parentWindow = default, int fetchSize = 20)
 	{
 		if (iShellFolder.EnumObjects(parentWindow, (SHCONTF)filter, out var eo).Failed)
+		{
 			Debug.WriteLine($"Unable to enum children in folder.");
+			yield break;
+		}
+
 		try
 		{
 			foreach (PIDL p in eo!.Enumerate(fetchSize))