Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempting to modernize dev_server #3

Merged
merged 3 commits into from
Mar 21, 2021
Merged

Conversation

bunnybones1
Copy link
Contributor

Hey there,
I have a need for something much like what you've written here.
I made a few edits to make it run against the latest deno/std and abc
It seems to work fine but I'm not entirely sure to be honest (I usually just do front-end dev and graphics)

Futhermore, I'm trying to get sourcemaps to work but it looks like CompilerOptions don't do anything with sourceMaps or inlineSourceMap
In fact most of the CompilerOptions I tried made no difference to the output.
I wonder if I was doing something wrong.

@zhmushan
Copy link
Owner

Thank you very much for spending time on this. Deno has changed a lot during this time, I will try your patch right away.

@zhmushan
Copy link
Owner

Futhermore, I'm trying to get sourcemaps to work but it looks like CompilerOptions don't do anything with sourceMaps or inlineSourceMap
In fact most of the CompilerOptions I tried made no difference to the output.
I wonder if I was doing something wrong.

Sorry not supported (denoland/deno#4499)

@bunnybones1
Copy link
Contributor Author

Thanks for confirming that. I hope that gets addressed in the near future.
Until then, I suppose productive development without source-maps is possible, but it's a different mindset :)

Copy link
Owner

@zhmushan zhmushan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, thanks for your pr

@zhmushan zhmushan merged commit b3443d3 into zhmushan:master Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants