Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

concat refactor #16

Open
wants to merge 276 commits into
base: refactor
Choose a base branch
from
Open

concat refactor #16

wants to merge 276 commits into from

Conversation

wentingj
Copy link

@wentingj wentingj commented Jan 11, 2018 •
edited
Loading

Description

  1. refact concat and pass nosetests:
    tests/python/unittest/test_operator.py:test_convolution_grouping
  2. issue is testing negative dim in test_concat will fail no matter use mkldnn or not.

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • For user-facing API changes, API doc string has been updated. For new C++ functions in header files, their functionalities and arguments are well-documented.
  • To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@zheng-da
Make batchnorm stateless.
f4c6f1c
@zheng-da
Make SoftmaxActivation stateless.
30b5fd9
@zheng-da
Fix a code style problem.
95ef90e
@zheng-da
pass amalgamation test for batch norm.
921859a
@zheng-da
pass amalgamation test for dropout.
485f58f
@zheng-da
Get convolution ops from a function.
660968f
@zheng-da
Fix compilation errors for GPU.
26e9430
@zheng-da
Fix thread local in diff platforms.
5504e2c
@zheng-da
Avoid using thread_local for non-CuDNN conv/deconv.
6324176
@zheng-da
Remove TODO in deconv.
36c466f
@zheng-da
Fix a compilation error in dropout.
6410684
@zheng-da
Fix a bug in batch norm.
1fa3898
@zheng-da
Fix a bug in fully connected.
588383a
@zheng-da
Don't set #inputs for backward convolution.
66a281a
@zheng-da
Remove MKL code.
d3ce902
@zheng-da
Update MXNet for MKLDNN.
caa3bf3
@zheng-da
Enable MKLDNN Relu.
db10bb1
@zheng-da
Fix a compilation error.
99c1e08
@zheng-da
Change Makefile for MKLDNN.
a6c2c82
@zheng-da
Remove infer storage in convolution.
3f75f52
@zheng-da
Update MXNet for MKLDNN.
edf6842
@zheng-da
Support MKLDNN storage type in python.
c96ca26
@zheng-da
Update activation.
1a6e06e
@zheng-da
Add MKLDNN base classes.
ca30cac
@zheng-da
Implement MKLDNN fully connected.
79c563c
@zheng-da
Add MKLDNN convolution.
2f5ed28
@zheng-da
Update MKLDNN interface in NDArray.
126b85e
@zheng-da
MKLDNN convolution handle CreateMKLDNNData failure.
7672608
@zheng-da
Add another GetMKLDNNData in NDArray.
4064bef
@zheng-da
Have mkldnn to define the data format.
9c6bf6f
zheng-da and others added 18 commits January 2, 2018 19:01
@zheng-da
Merge branch 'refactor' of https://github.com/zheng-da/incubator-mxnet …
c8578c0 
…into refactor
@zheng-da
Handle weight arrays with special MKLDNN layouts.
ac8f9fd
@zheng-da
Remove unnecessary GetWeights.
24200a0
@zheng-da
Fix compilation error without MKLDNN.
19d8749
@zheng-da
Fix a bug in (de)conv for weight arrays.
18236fc
@zheng-da
Fix a minor bug in MKLDNN conv.
1cd8bad
@zheng-da
Avoid caching TBlob from NDArray.
9b3c8b2 
This commit may add some overhead of managing NDArray for each fallback.
@zheng-da
Fix a bug in MKLDNNOpSignature.
c426bfa
@TaoLv
Merge remote-tracking branch 'da/refactor' into bn-primitive
623b994 
Conflicts:
	src/operator/nn/mkldnn/mkldnn_batch_norm-inl.h
@TaoLv
1. Fix coding style in BatchNorm;
5825191 
2. Add memory into signature;
3. Try to split BatchNorm into .h file and .cc file. Will finish it after backward code is refactored.
@zheng-da
Merge pull request zheng-da#5 from TaoLv/bn-primitive
87fd9d5 
Caching primitive for BatchNorm forward computation
@zheng-da
Update mkldnn_base-inl.h
7c957ef
OP primitive cache: use memory as signature for MKLDNN storage type
b4cdd13
@TaoLv
Add primitive caching for Pooling forward computation
15199c7
@zheng-da
Merge pull request zheng-da#13 from TaoLv/pooling-primitive
e814b3e 
Add primitive caching for Pooling forward computation
@zheng-da
Merge pull request zheng-da#11 from jinhuang415/refactor_pr1
1cba97f 
OP primitive cache: use memory as signature for MKLDNN storage type
@wentingj
concat refactor
624f0a9
@wentingj
update op register file
235f653
@zheng-da zheng-da force-pushed the refactor branch 8 times, most recently from ba474be to 5cb7ca0 Compare January 17, 2018 18:50
zheng-da added a commit that referenced this pull request Jun 13, 2018
@zheng-da @reminisce
execute subgraph operators synchronously (#16)
1bdb7d7 
* execute subgraph operators correctly.

* add HasSubgraph attr.

* support subgraph op in imperative.

* rewrite running subgraph in main thread.

* execute subgraph op in imperative.

* remove need_grad.
TaoLv pushed a commit to TaoLv/incubator-mxnet that referenced this pull request Jun 16, 2018
@zheng-da @reminisce
execute subgraph operators synchronously (zheng-da#16)
dda22e9 
* execute subgraph operators correctly.

* add HasSubgraph attr.

* support subgraph op in imperative.

* rewrite running subgraph in main thread.

* execute subgraph op in imperative.

* remove need_grad.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wentingj @zheng-da @TaoLv @ashokei @pengzhao-intel