config option for additionalProperties on false by default

[remuspoienar]

Hi,

Thanks for writing this library !

Got used to most of the DSLs provided and was wondering if there is a way to configure additionalProperties to be implicitly false on all schemas/subschemas if not specified.

I'd like to be able to either configure it globally in the configuration file or in a schema object and have it applied on all schemas that are nested.

[zhandao]

The code to handle additionalProperties is: https://github.com/zhandao/zero-rails_openapi/blob/master/lib/oas_objs/schema_obj.rb#L58

Do you mean, when additionalProperties is not specified, this line of code returns a { additionalProperties: false }? (And the behavior is configurable?)

[remuspoienar]

Yes, that is indeed the behaviour i would like, since in OAS3 additionalProperties is true by default. And i think this should be configurable, since it is not desirable for everyone that uses the library. I use api response validation in tests based on the swagger definition, and i want my tests to fail if new fields are added (when additionalProperties is false in the definition) or removed(when fields are required in the definition).
So adding additionalProperties: false on every schema and nested schemas inside will greatly bloat my code, since its always the same value on every schema

As an example for the following data structure
{ a: { b: { c: { d: 'some string' } } } }

i would have the following schema in the components section of a doc

schema SomeSchema: [ { a!: [ { b!: [ { c!: [ { d!: String }, additional_properties: false ], }, additional_properties: false ] }, additional_properties: false ] }, additional_properties: false ]

If i write in the initializer file something like
self.implicit_additional_properties_value = false

Then i could simplify the above code like this

schema SomeSchema: [ { a!: { b!: { c!: { d!: String } } } } ]

[zhandao]

OK, I'll do this in a few hours.

[zhandao]

Done. Try the latest version 2.1.3.

[remuspoienar]

Works great. Thanks so much !