This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Handle PHP 7+ Throwable (also before defaulting to status 406) #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added notes about zend-component-installer - used stable package version - short array notation
- added coveralls configuration - coverage badge in README - added composer scripts - updated travis configuration - phpunit.xml changed to .dist - updated .gitignore
- travis SVG image instead of PNG - master branch
…ble. instanceof exception condition was retained for PHP <7.
|
Requires tests. Consider basing your additional changes off of #52? |
Docs fixes + Code coverage
Handle PHP 7 Throwables in ApiProblemListener Conflicts: composer.lock
Handle PHP 7+ Throwable (also before defaulting to status 406) Conflicts: src/Listener/ApiProblemListener.php
Adds two new test cases for zfcampus#55, one each for testing exceptions and throwables (the latter depends on PHP 7.0).
Install all deps always, but then downgrade if we are running under PHP 5.6.
|
Changes Unknown when pulling 19a4ebd on im-bart:hotfix/handle_throwable into ** on zfcampus:master**. |
|
@im-bart I've rebased against current master, added tests, and pushed changes to your fork. Travis is now green, so I'll merge. Thanks! |
weierophinney
added a commit
that referenced
this pull request
Jul 24, 2017
weierophinney
added a commit
that referenced
this pull request
Jul 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As PR #52, but also handles onRenderError (possibly returning a 406 on what could well be a 500).