This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Prepare zf-api-problem for v3 components #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-syntax Use short array syntax
- It's completely unnecessary, as Composer manages this module.
- Bumped minimum required PHP to 5.6, and allows 7 now. - Used `||` notation where multiple major versions are possible. - Removed console; we can test with a stdlib request.
- Added `$priority = 1` optional argument defined in v3 to `attach()` signatures.
Added namespace to configuration file to allow usage of `::class` notation.
This patch ensures that all listener aggregates use the form:
```php
$aggregate->attach($events);
```
vs
```php
$events->attach($aggregate);
```
as the latter is unsupported in v3 versions of zend-eventmanager.
weierophinney
added a commit
that referenced
this pull request
Jul 6, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates and supercedes #36, with the following changes:
||notation when multiple major versions exist.RequestInterfacemock.getAutoloaderConfig()implementation, as it's superfluous in a Composer-managed project.$priority = 1argument inattach()implementations.::classnotation.