This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Added content-type constant to class ApiProblem #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added constant with content-type in the ApiProblem class so it can be used in other classes that need this content_type variable. It will just make referring to the correct content-type much easier. ```` $contentType = ApiProblem::CONTENT_TYPE; ````
Instead of hard coding a string for the content-type we reuse the constant from the ApiProblem class here
Used constant from ApiProblem
Used constant from ApiProblem
Used constant from ApiProblem
Used constant from ApiProblem
Used constant from ApiProblem
Declared ApiProblem in the test class
Removed white space for travis
weierophinney
added a commit
that referenced
this pull request
Jul 6, 2016
Added content-type constant to class ApiProblem
weierophinney
added a commit
that referenced
this pull request
Jul 6, 2016
weierophinney
added a commit
that referenced
this pull request
Jul 6, 2016
|
Merged to develop for release with 1.2.0; thanks, @Wilt ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a content-type constant to the class ApiProblem and used it inside the ApiProblemResponse class. It will make it much easier to refer to the correct content type without having to retype/hardcode the
application/problem+jsonstring everywhere we need it.