This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
json_encode fails for streams #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 16, 2015 16:36
ApiProblem was not able to render exceptions when the option
ApiProblem::detailIncludesStackTrace was true and the exception contained
PHP streams in the arguments of the traces ("args" key in
Exception::getTraces()). For example: GuzzleHttp works internally with
streams which meant that some exceptions raised from GuzzleHttp didn't
result in a ApiProblem response but in an empty 500 response because
json_encode() failed.
The check for the availability of JSON_UNESCAPED_SLASHES is redundant because we already require php >= 5.5 in composer.json and the constant was introduced in PHP 5.4. Also an check for the availability of ext-json was added to ensure functions like json_encode() and the json constants are available.
|
Whats the status of this PR? Does it need any additional work or information? |
weierophinney
added a commit
that referenced
this pull request
Jul 6, 2016
…r-objects
json_encode fails for streams
Conflicts:
composer.json
weierophinney
added a commit
that referenced
this pull request
Jul 6, 2016
weierophinney
added a commit
that referenced
this pull request
Jul 6, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will quote the message from commit 5f7043e:
This PR fixes this issue.
The contribution guidelines didn't specify when to pull request against which branch, so if develop is not the correct target branch for the pull request, please let me know.
Thank you for considering my pull request.