-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap update (v5.3.3) for CSS and JS #97
Conversation
zetxek
commented
Dec 14, 2024
•
edited
Loading
edited
- Update to Bootstrap 5.3.3 (from 4.3.1)
- Switch to Bootstrap Scss
The prod build breaks the CSS (https://adritian-demo-git-theme-update-update-theme-4e27f0-adrianmoreno.vercel.app/): ![]() In the development version it looks ok ![]() |
For easier updates
The one to blame for overly aggresive CSS removal
Consistency for css and scss
Taking shape.
2024-12-15.15.30.20.mp42024-12-15.15.32.01.mp4The idea is to separate the bootstrap-specific files from the rest of the theme, so it can be updated easier (or split from bootstrap in the future). Pending:
|
The page load seems to be comparable for the pre-release version and the current production one
![]() |
// fusv-enable | ||
|
||
// scss-docs-start color-variables | ||
$blue: #478079 !default; // adritian override |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adritian custom blue
md: 720px, | ||
lg: 960px, | ||
xl: 1140px, | ||
xxl: 1200px, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another override/customization on the defaults
The demo site doesn't build right away due to some changes in the config - but seems to be doing well layout-wise: Updating to Bootstrap 5 with Sass will be worth it as the customizations are quite much cleaner, using |
The speed is confirmed still in production 🎉 Just tested adrianmoreno.info in mobile and desktop after zetxek/adrianmoreno.info#235, and the score in lighthouse is still 100/100/100/100 (performance/accessibility/best practices/SEO) |
Nice @zetxek I will try to update my site during the week, amazing work 🔝 |
fantastic! If you find any issue - we can update the docs in https://github.com/zetxek/adritian-free-hugo-theme/blob/main/upgrading.md |
Hi @zetxek I updated my site with the last release, after following the upgrading.md all works great for now i didn't notice any break on my site. Thanks for that big update! 🎉 |