Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap update (v5.3.3) for CSS and JS #97

Merged
merged 24 commits into from
Dec 15, 2024
Merged

Bootstrap update (v5.3.3) for CSS and JS #97

merged 24 commits into from
Dec 15, 2024

Conversation

zetxek
Copy link
Owner

@zetxek zetxek commented Dec 14, 2024

  • Update to Bootstrap 5.3.3 (from 4.3.1)
  • Switch to Bootstrap Scss

@zetxek
Copy link
Owner Author

zetxek commented Dec 14, 2024

The prod build breaks the CSS (https://adritian-demo-git-theme-update-update-theme-4e27f0-adrianmoreno.vercel.app/):

image

In the development version it looks ok

image

For easier updates
The one to blame for overly aggresive CSS removal
Consistency for css and scss
@zetxek
Copy link
Owner Author

zetxek commented Dec 15, 2024

Taking shape.

  • Left: new version
  • Right: current prod version
2024-12-15.15.30.20.mp4
2024-12-15.15.32.01.mp4

The idea is to separate the bootstrap-specific files from the rest of the theme, so it can be updated easier (or split from bootstrap in the future).

Pending:

  • applying PostCSS for CSS optimization
  • review dark theme

@zetxek zetxek changed the title Update/bootstrap Bootstrap update (v5.3.3) for CSS and JS Dec 15, 2024
@zetxek
Copy link
Owner Author

zetxek commented Dec 15, 2024

The page load seems to be comparable for the pre-release version and the current production one

image

// fusv-enable

// scss-docs-start color-variables
$blue: #478079 !default; // adritian override
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adritian custom blue

md: 720px,
lg: 960px,
xl: 1140px,
xxl: 1200px,
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another override/customization on the defaults

@zetxek
Copy link
Owner Author

zetxek commented Dec 15, 2024

The demo site doesn't build right away due to some changes in the config - but seems to be doing well layout-wise:

zetxek/adritian-demo#94

Updating to Bootstrap 5 with Sass will be worth it as the customizations are quite much cleaner, using variables.
Excited about this facelift to the theme!

@zetxek zetxek merged commit 1660bfd into main Dec 15, 2024
3 of 4 checks passed
@zetxek zetxek deleted the update/bootstrap branch December 15, 2024 21:06
@zetxek
Copy link
Owner Author

zetxek commented Dec 15, 2024

The speed is confirmed still in production 🎉

Just tested adrianmoreno.info in mobile and desktop after zetxek/adrianmoreno.info#235, and the score in lighthouse is still 100/100/100/100 (performance/accessibility/best practices/SEO)

2024-12-15 22 26 18
2024-12-15 22 26 51

@dcorto
Copy link
Collaborator

dcorto commented Dec 16, 2024

Nice @zetxek I will try to update my site during the week, amazing work 🔝

@zetxek
Copy link
Owner Author

zetxek commented Dec 16, 2024

Nice @zetxek I will try to update my site during the week, amazing work 🔝

fantastic! If you find any issue - we can update the docs in https://github.com/zetxek/adritian-free-hugo-theme/blob/main/upgrading.md
For a while I didn't want to make any breaking changes - but I wonder how many people upgrade the theme... and even if they do, some improvements are worth the manual update!

@dcorto
Copy link
Collaborator

dcorto commented Dec 17, 2024

Nice @zetxek I will try to update my site during the week, amazing work 🔝

fantastic! If you find any issue - we can update the docs in https://github.com/zetxek/adritian-free-hugo-theme/blob/main/upgrading.md For a while I didn't want to make any breaking changes - but I wonder how many people upgrade the theme... and even if they do, some improvements are worth the manual update!

Hi @zetxek I updated my site with the last release, after following the upgrading.md all works great for now i didn't notice any break on my site. Thanks for that big update! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants