[1.5.x] hugo modules (bootstrap included) #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3d0e9bf.
- Commented out Bootstrap and Popper.js module imports in config.toml and hugo.toml to address discussions on theme usage. - Enhanced README.md to improve clarity on theme features, installation methods, and Bootstrap integration, emphasizing accessibility and performance improvements.
dcorto
approved these changes
Jan 23, 2025
|
Merging to #166 - I think that to modularize the repo we can go in smaller steps, and see what makes sense for the best compatibility :) |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note PS: the version was meant to be 2.0.0 but due to complications with go modules, the version has become 1.5.0.
See #171 for more information.
As mentioned in #158 (reply in thread), I'm leaning more to keeping bootstrap in the theme - to make it easier to use.
This PR is a "else" for #166, another version of how the theme can support hugo modules without removing bootstrap - therefore keeping compatibility with
git submodules, as well as "download, copy and play".I made sure that the theme files are used by overriding/playing with the color:
Aside of that, respect #166 , the other change is a bit of update on the README.