Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated build pipeline and upload-to-s3 actions to upload files to ex… #765

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

gzukel
Copy link
Contributor

@gzukel gzukel commented Jun 29, 2023

Description

updated build pipeline and upload-to-s3 actions to upload files to external file download in s3 bucket path. Fixed the upload-to-s3 pipeline to use the inputs for the composite action instead of env vars.

Closes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Yes this has been tested by creating new tag and watching it work.

@CharlieMc0
Copy link
Member

Looks good to me. Just need to update PR title to match semantic commit format before it can be merged. fix: ci - upload-to-s3 actions to upload files to ex...

@gzukel gzukel merged commit 16cf5e6 into develop Jun 29, 2023
@lumtis lumtis deleted the add-public-upload branch October 27, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants