feat: add/refactor port 8123 telemetry in zetalient #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move constructor out of NewTSS; add lastStartTimestamp add lastScannedBlock on each chain
CharlieMc0
reviewed
Jun 15, 2023
| router.HandleFunc("/debug/pprof/", pprof.Index) | ||
| router.HandleFunc("/debug/pprof/cmdline", pprof.Cmdline) | ||
|
|
||
| //router.Handle("/pending", http.HandlerFunc(t.pendingHandler)).Methods(http.MethodGet) |
There was a problem hiding this comment.
Is this for pending CCTXs? Why not include it?
There was a problem hiding this comment.
Our rpc improved so pending txs can be queried form node rpc efficiently. This is no longer needed.
Comment on lines
+79
to
+84
| func (t *TelemetryServer) SetCoreBlockNumber(blockNumber int64) { | ||
| t.mu.Lock() | ||
| t.lastCoreBlockNumber = blockNumber | ||
| t.mu.Unlock() | ||
| } | ||
|
|
There was a problem hiding this comment.
What is this function for? Does it cause zetaclient to rescan older blocks?
There was a problem hiding this comment.
I see now there is no routing. At first I thought this was something you could hit externally via the 8123 endpoint
There was a problem hiding this comment.
this is a setter to feed info into telemetry server.
kingpinXD
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move constructor out of NewTSS;
add lastStartTimestamp
add lastScannedBlock on each chain
add lastCoreBlock on zetacore
closes #682 #699
added telemetry items:
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Closes:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: