Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Halborn audit issue 14, revert mint if failed transfer of ZETA #697

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

aldapp7
Copy link
Contributor

@aldapp7 aldapp7 commented Jun 9, 2023

Description

Resolves HAL issue 14. Reverts ZETA minting if later logic fails, including ZETA transfer. Better error handling.

Closes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@aldapp7 aldapp7 requested a review from brewmaster012 June 9, 2023 15:20
@aldapp7 aldapp7 self-assigned this Jun 9, 2023
@aldapp7 aldapp7 marked this pull request as ready for review June 9, 2023 15:20
Copy link
Collaborator

@brewmaster012 brewmaster012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brewmaster012
Copy link
Collaborator

would be nice if @kingpinXD can also take a look.

@kingpinXD
Copy link
Contributor

would be nice if @kingpinXD can also take a look.

Discussed with vlad already, this looks like a good fix for now, until we figure out a better way to manage the state in a branch

@aldapp7 aldapp7 merged commit b54b03b into develop Jun 12, 2023
@lumtis lumtis deleted the fix/mint_zeta branch October 27, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants