-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade cosmovisor and go #3345
Conversation
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe pull request introduces a version update for the Changes
Sequence DiagramsequenceDiagram
participant Build as Docker Build Process
participant Cosmovisor as Cosmovisor Tool
Build->>Cosmovisor: Install cosmovisor@v1.7.0
Cosmovisor-->>Build: Tool installed successfully
The sequence diagram illustrates the straightforward process of installing the updated version of cosmovisor during the Docker build stage, highlighting the version upgrade from the previous implementation. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
7227468
to
7396fc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering, any benefits we would get from upgrading the repo to 1.23 as well at some point?
Until we import a package that specifically requires and uses a 1.23 feature no. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3345 +/- ##
===========================================
+ Coverage 61.91% 62.43% +0.52%
===========================================
Files 445 449 +4
Lines 31501 31710 +209
===========================================
+ Hits 19503 19799 +296
+ Misses 11127 11024 -103
- Partials 871 887 +16
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://github.com/cosmos/cosmos-sdk/releases/tag/cosmovisor%2Fv1.7.0
Requires go 1.23 for some reason.
goreleaser-cross hasn't published a 1.23.4 so sticking with 1.23.3
Summary by CodeRabbit
cosmovisor
tool from version 1.6.0 to version 1.7.0 in the build process