Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade cosmovisor and go #3345

Merged
merged 5 commits into from
Jan 13, 2025
Merged

chore: upgrade cosmovisor and go #3345

merged 5 commits into from
Jan 13, 2025

Conversation

gartnera
Copy link
Member

@gartnera gartnera commented Jan 10, 2025

https://github.com/cosmos/cosmos-sdk/releases/tag/cosmovisor%2Fv1.7.0

Requires go 1.23 for some reason.

goreleaser-cross hasn't published a 1.23.4 so sticking with 1.23.3

Summary by CodeRabbit

  • Chores
    • Updated cosmovisor tool from version 1.6.0 to version 1.7.0 in the build process

@gartnera gartnera added the UPGRADE_LIGHT_TESTS Run make start-upgrade-test-light label Jan 10, 2025
@gartnera gartnera requested a review from a team as a code owner January 10, 2025 17:21
Copy link
Contributor

coderabbitai bot commented Jan 10, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

The pull request introduces a version update for the cosmovisor tool in the Dockerfile-localnet. The modification involves upgrading the installation command from version v1.6.0 to v1.7.0, which will impact the build process for the Docker image's cosmovisor-build stage. This change ensures the utilization of the latest version of the cosmovisor tool during image creation.

Changes

File Change Summary
Dockerfile-localnet Updated cosmovisor installation command from v1.6.0 to v1.7.0

Sequence Diagram

sequenceDiagram
    participant Build as Docker Build Process
    participant Cosmovisor as Cosmovisor Tool
    
    Build->>Cosmovisor: Install cosmovisor@v1.7.0
    Cosmovisor-->>Build: Tool installed successfully
Loading

The sequence diagram illustrates the straightforward process of installing the updated version of cosmovisor during the Docker build stage, highlighting the version upgrade from the previous implementation.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gartnera gartnera added the no-changelog Skip changelog CI check label Jan 10, 2025
@gartnera gartnera marked this pull request as draft January 10, 2025 17:25
@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label Jan 10, 2025
@gartnera gartnera changed the title chore: upgrade cosmovisor chore: upgrade cosmovisor and go Jan 10, 2025
@gartnera gartnera marked this pull request as ready for review January 10, 2025 18:37
@gartnera gartnera requested a review from a team as a code owner January 10, 2025 18:37
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering, any benefits we would get from upgrading the repo to 1.23 as well at some point?

@gartnera
Copy link
Member Author

Wondering, any benefits we would get from upgrading the repo to 1.23 as well at some point?

Until we import a package that specifically requires and uses a 1.23 feature no.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.43%. Comparing base (2edfa9c) to head (f8617fa).
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3345      +/-   ##
===========================================
+ Coverage    61.91%   62.43%   +0.52%     
===========================================
  Files          445      449       +4     
  Lines        31501    31710     +209     
===========================================
+ Hits         19503    19799     +296     
+ Misses       11127    11024     -103     
- Partials       871      887      +16     
Files with missing lines Coverage Δ
pkg/graceful/graceful.go 86.31% <100.00%> (ø)
x/observer/types/ballot.go 100.00% <100.00%> (ø)

... and 29 files with indirect coverage changes

@gartnera gartnera enabled auto-merge January 13, 2025 19:51
Copy link
Contributor

@morde08 morde08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gartnera gartnera added this pull request to the merge queue Jan 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2025
@gartnera gartnera added this pull request to the merge queue Jan 13, 2025
Merged via the queue into develop with commit 8559390 Jan 13, 2025
40 checks passed
@gartnera gartnera deleted the upgrade-cosmovisor branch January 13, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI pipeline or github actions no-changelog Skip changelog CI check UPGRADE_LIGHT_TESTS Run make start-upgrade-test-light
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants