feat: zetaclient should be able to activate/deactivate chains at runtime

changelog.md

@@ -148,7 +148,7 @@
 * [1848](https://github.com/zeta-chain/node/issues/1848) - create a method to observe deposits to tss address in one evm block
 * [1885](https://github.com/zeta-chain/node/pull/1885) - change important metrics on port 8123 to be prometheus compatible
 * [1863](https://github.com/zeta-chain/node/pull/1863) - remove duplicate ValidateChainParams function
-* [1914](https://github.com/zeta-chain/node/pull/1914) - move crosschain flags to core context in zetaclient
+* [1914](https://github.com/zeta-chain/node/pull/1914) - move crosschain flags to app context in zetaclient
 * [1948](https://github.com/zeta-chain/node/pull/1948) - remove deprecated GetTSSAddress query in crosschain module
 * [1936](https://github.com/zeta-chain/node/pull/1936) - refactor common package into subpackages and rename to pkg
 * [1966](https://github.com/zeta-chain/node/pull/1966) - move TSS vote message from crosschain to observer
@@ -177,6 +177,7 @@
 * [2046](https://github.com/zeta-chain/node/pull/2046) - add state variable in crosschain for rate limiter flags
 * [2034](https://github.com/zeta-chain/node/pull/2034) - add support for zEVM message passing
 * [1825](https://github.com/zeta-chain/node/pull/1825) - add a message to withdraw emission rewards
+* [2411](https://github.com/zeta-chain/node/pull/2411) - zetaclient activates and deactivates chains at runtime
 
 ### Tests
 

cmd/zetaclientd/debug.go

@@ -11,7 +11,6 @@ import (
 	ethcommon "github.com/ethereum/go-ethereum/common"
 	"github.com/ethereum/go-ethereum/ethclient"
 	"github.com/onrik/ethrpc"
-	"github.com/rs/zerolog"
 	"github.com/spf13/cobra"
 
 	"github.com/zeta-chain/zetacore/pkg/chains"
@@ -57,7 +56,7 @@ func debugCmd(_ *cobra.Command, args []string) error {
 		return err
 	}
 
-	appContext := clientcontext.New(cfg, zerolog.Nop())
+	appContext := clientcontext.New(cfg)
 
 	chainID, err := strconv.ParseInt(args[1], 10, 64)
 	if err != nil {
@@ -131,7 +130,7 @@ func debugCmd(_ *cobra.Command, args []string) error {
 					ZetaTokenContractAddress:    chainParams.ZetaTokenContractAddress,
 					Erc20CustodyContractAddress: chainParams.Erc20CustodyContractAddress,
 				})
-				evmChainParams, found := appContext.GetEVMChainParams(chainID)
+				evmChainParams, found := appContext.GetExternalChainParams(chainID)
 				if !found {
 					return fmt.Errorf("missing chain params for chain %d", chainID)
 				}

cmd/zetaclientd/keygen_tss.go

@@ -22,7 +22,8 @@ import (
 	"github.com/zeta-chain/zetacore/zetaclient/zetacore"
 )
 
-func GenerateTss(
+// GenerateTSS waits for the keygen block height to arrive and generates a new TSS
+func GenerateTSS(
 	appContext *context.AppContext,
 	logger zerolog.Logger,
 	client *zetacore.Client,
@@ -31,26 +32,17 @@ func GenerateTss(
 	ts *metrics.TelemetryServer,
 	tssHistoricalList []observertypes.TSS,
 	tssPassword string,
-	hotkeyPassword string) (*mc.TSS, error) {
+	hotkeyPassword string,
+) (*mc.TSS, error) {
 	keygenLogger := logger.With().Str("module", "keygen").Logger()
 
-	// Bitcoin chain ID is currently used for using the correct signature format
-	// TODO: remove this once we have a better way to determine the signature format
-	// https://github.com/zeta-chain/node/issues/1397
-	bitcoinChainID := chains.BitcoinRegtest.ChainId
-	btcChain, _, btcEnabled := appContext.GetBTCChainAndConfig()
-	if btcEnabled {
-		bitcoinChainID = btcChain.ChainId
-	}
-
 	tss, err := mc.NewTSS(
 		appContext,
 		peers,
 		priKey,
 		preParams,
 		client,
 		tssHistoricalList,
-		bitcoinChainID,
 		tssPassword,
 		hotkeyPassword,
 	)
@@ -74,7 +66,11 @@ func GenerateTss(
 		// This loop will try keygen at the keygen block and then wait for keygen to be successfully reported by all nodes before breaking out of the loop.
 		// If keygen is unsuccessful, it will reset the triedKeygenAtBlock flag and try again at a new keygen block.
 
-		keyGen := appContext.GetKeygen()
+		keyGen, err := client.GetKeyGen()
+		if err != nil {
+			keygenLogger.Error().Err(err).Msg("GetKeyGen error")
+			continue
+		}
 		if keyGen.Status == observertypes.KeygenStatus_KeyGenSuccess {
 			return tss, nil
 		}
@@ -107,7 +103,7 @@ func GenerateTss(
 				}
 				// Try keygen only once at a particular block, irrespective of whether it is successful or failure
 				triedKeygenAtBlock = true
-				err = keygenTss(keyGen, tss, keygenLogger)
+				err = keygenTss(*keyGen, tss, keygenLogger)
 				if err != nil {
 					keygenLogger.Error().Err(err).Msg("keygenTss error")
 					tssFailedVoteHash, err := client.SetTSS("", keyGen.BlockNumber, chains.ReceiveStatus_failed)