-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: synthetic eth txs unit tests #2342
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2342 +/- ##
==========================================
Coverage ? 68.74%
==========================================
Files ? 302
Lines ? 19180
Branches ? 0
==========================================
Hits ? 13186
Misses ? 5347
Partials ? 647
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comments
Ideal testing is with some livenet with explorer, we can discuss in summary doc how to test manually.
Maybe with a E2E test?
yes lets discuss how to add e2e tests maybe |
Description
NOTE: don't merge yet, base branch is different PR that should be merged first.
Adds more unit tests to test changes introduced in #2282. A bit tricky to test this with unit tests as it requires a lot of setup and mocking but should be good enough to confirm happy paths are working fine. Ideal testing is with some livenet with explorer, we can discuss in summary doc how to test manually.
Closes: #2301
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: