Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: synthetic eth txs unit tests #2342

Merged
merged 24 commits into from
Jun 19, 2024
Merged

Conversation

skosito
Copy link
Contributor

@skosito skosito commented Jun 14, 2024

Description

NOTE: don't merge yet, base branch is different PR that should be merged first.

Adds more unit tests to test changes introduced in #2282. A bit tricky to test this with unit tests as it requires a lot of setup and mocking but should be good enough to confirm happy paths are working fine. Ideal testing is with some livenet with explorer, we can discuss in summary doc how to test manually.

Closes: #2301

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@a292450). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2342   +/-   ##
==========================================
  Coverage           ?   68.74%           
==========================================
  Files              ?      302           
  Lines              ?    19180           
  Branches           ?        0           
==========================================
  Hits               ?    13186           
  Misses             ?     5347           
  Partials           ?      647           
Files Coverage Δ
x/fungible/keeper/evm.go 87.81% <ø> (ø)
rpc/types/events.go 44.49% <0.00%> (ø)

@skosito skosito marked this pull request as ready for review June 17, 2024 22:56
@skosito skosito linked an issue Jun 17, 2024 that may be closed by this pull request
Copy link
Member

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments

Ideal testing is with some livenet with explorer, we can discuss in summary doc how to test manually.

Maybe with a E2E test?

@skosito
Copy link
Contributor Author

skosito commented Jun 18, 2024

LGTM, minor comments

Ideal testing is with some livenet with explorer, we can discuss in summary doc how to test manually.

Maybe with a E2E test?

yes lets discuss how to add e2e tests maybe

Base automatically changed from rpc-tests-todo to develop June 19, 2024 17:40
@skosito skosito requested a review from swift1337 as a code owner June 19, 2024 17:40
@skosito skosito merged commit f5a7aae into develop Jun 19, 2024
19 checks passed
@skosito skosito deleted the synthetic-eth-txs-unit-tests branch June 19, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend rpc unit tests to test synthetic txs handling
3 participants