Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add authorization list for policy transactions #2289

Merged
merged 20 commits into from
May 31, 2024
Merged

Conversation

kingpinXD
Copy link
Contributor

Description

  • This pr adds a new authorization list
  • It adds the Get,Set and Genesis methods for the newly added state
  • It defines the type and adds functions to modify the list

Closes:#2246

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@kingpinXD kingpinXD changed the title feat : add authotization list for policy transactions feat: add authotization list for policy transactions May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 98.43750% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 69.25%. Comparing base (0e75423) to head (c61594b).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2289      +/-   ##
===========================================
+ Coverage    69.14%   69.25%   +0.11%     
===========================================
  Files          272      274       +2     
  Lines        16472    16535      +63     
===========================================
+ Hits         11389    11452      +63     
  Misses        4599     4599              
  Partials       484      484              
Files Coverage Δ
x/authority/genesis.go 100.00% <100.00%> (ø)
x/authority/keeper/authorization_list.go 100.00% <100.00%> (ø)
x/authority/types/authorizations.go 100.00% <100.00%> (ø)
app/setup_handlers.go 0.00% <0.00%> (ø)

@kingpinXD kingpinXD marked this pull request as ready for review May 29, 2024 17:58
@lumtis lumtis changed the title feat: add authotization list for policy transactions feat: add authorization list for policy transactions May 30, 2024
@kingpinXD kingpinXD requested a review from lumtis May 30, 2024 19:23
@kingpinXD kingpinXD requested a review from lumtis May 31, 2024 01:47
@kingpinXD kingpinXD requested a review from lumtis May 31, 2024 12:56
@kingpinXD kingpinXD merged commit 54de761 into develop May 31, 2024
19 checks passed
@kingpinXD kingpinXD deleted the authority-table branch May 31, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants