-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ibc-crosschain
module
#2154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skosito
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just some small comments
kingpinXD
reviewed
May 13, 2024
kingpinXD
reviewed
May 13, 2024
kingpinXD
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Tanmay <tanmay@zetachain.com>
Co-authored-by: Tanmay <tanmay@zetachain.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
ibc-crosschain
module. The module is currently empty but take ibcTransfer and crosschain modules as a dependencies for future workAdd placeholders in
ibc-crosschain
to implement the IBCModule interfaceAdd
ibc-crosschain
module as a dep tocrosschain
. Since there is a circular dep, crosschain must be first initialized, passed to ibc-crosschain when initialized, the call theSetIBCTransferKeeper
in crosschain to set the ibc-crosschain keeperUpdate testkeeper package to add capability, ibc and ibc-transfer modules to SDK modules, add ibc-crosschain module and update crosschain dep
Closes: #2128