Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ibc-crosschain module #2154

Merged
merged 23 commits into from
May 14, 2024
Merged

feat: add ibc-crosschain module #2154

merged 23 commits into from
May 14, 2024

Conversation

lumtis
Copy link
Member

@lumtis lumtis commented May 10, 2024

Description

  • Add ibc-crosschain module. The module is currently empty but take ibcTransfer and crosschain modules as a dependencies for future work

  • Add placeholders in ibc-crosschain to implement the IBCModule interface

  • Add ibc-crosschain module as a dep to crosschain. Since there is a circular dep, crosschain must be first initialized, passed to ibc-crosschain when initialized, the call the SetIBCTransferKeeper in crosschain to set the ibc-crosschain keeper

  • Update testkeeper package to add capability, ibc and ibc-transfer modules to SDK modules, add ibc-crosschain module and update crosschain dep

Closes: #2128

@lumtis lumtis marked this pull request as ready for review May 13, 2024 10:56
Copy link
Contributor

@skosito skosito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just some small comments

Copy link
Contributor

@kingpinXD kingpinXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

lumtis and others added 3 commits May 14, 2024 08:58
@lumtis lumtis merged commit c184851 into develop May 14, 2024
21 checks passed
@lumtis lumtis deleted the feat/ibc-crosschain branch May 14, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialize the module ibc-crosschain
3 participants