Use twine.cli.dispatch() to run twine #284
Conversation
|
I know this code has conflict, but I wanted to have a pull-request to refer to in the pypa/twine pull/361 for the case I'm deleting my fork. |
Move a few lines down to where they are related to.
Use twine.cli.dispatch(), passing it command-line arguments. The error handling needed to be changed, too, since twine does not return an result code, but raises an error in failure. Even if twine does not offer a stable API the command-line interface should be acceptable stable, thus talking to twine at (nearly) command-line level should be okay. If twine.cli.dispatch() vanishes or changes, an acceptable supplement should be easy to find.
701740e to
0e6c331
Compare
|
I just rebased on current master and resolved the conflicts. The discussion about an API for twine did not show any results and what is discussed there is much too detailed. Thus I suggest to not wait for twine providing some documented API, but use this high-level function call. Please note: The CI-tests for Python 2.7 fail when trying to install git-svn, see#307. Otehr tests fail with a stale build. |
|
Let's hope that twine doesn't remove/hide the perfectly fine cli "api". A well, we can always just call it on the command line.... That's what we did with |
See #238 (comment):
I tried this and found myself re-implementing quite some parts of
twine.commands.upload#upload(). Not only one would need to filter out the.ascfiles first, but alsoadd_gpg_signatureto each file to be uploaded, if the signature exists. Although this would still be only a view lines, keeping up with twine features and PyPI API changes would become a cat-and-mice-game in he long run.I asked for another high-level api (see pypa/twine#194 (comment)), one of which
twine.cli.dispatch()could be. This would allow something like: