misc: fix crash when quitting consecutive games #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkalkbrenner
reviewed
Dec 7, 2024
There was a problem hiding this comment.
These changes seem to be correct.
Nevertheless @zesinger should test on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we finish up development of the Android Visual Pinball app, we noticed a crash in libserum.
To reproduce the issue:
Play Iron Man, Quit Iron Man, Play Diner, Quit Diner, crash
The memory was being freed, but the pointer still had the old reference in it instead of
null.This never was an issue for standalone before, because it was always run and done.
But the mobile apps, and I suspect Windows, have this issue since your not exiting the application after each table.