Problem: missing tests and inconsistent behaviour for ZAP corner cases #2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: added test case for NULL/PLAIN/CURVE
Solution: emit events as expected by tests, and refuse connections when ZAP is required but no handler started Addresses zeromq#2711 partially
Solution: added test & some improvements of test utils
mechanisms Solution: uniformly require a ZAP domain to be set to activate ZAP handling, clarify comment on Stonehouse pattern
bluca
reviewed
Sep 18, 2017
tests/testutil_security.hpp
Outdated
| @@ -183,6 +202,8 @@ void zap_handler_generic (void *ctx, | |||
| char *version = s_recv (handler); | |||
| if (!version) | |||
| break; // Terminating - peer's socket closed | |||
| if (zap_protocol == zap_disconnect) | |||
| break; | |||
Solution: added tests
07eb193 to
77f76a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: added tests & aligned behaviour
Fixes #2711