Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paths used in comparisons must be normalized #7

Closed
pepone opened this issue Jan 15, 2021 · 1 comment
Closed

Paths used in comparisons must be normalized #7

pepone opened this issue Jan 15, 2021 · 1 comment
Assignees
@pepone
Labels
bug

Comments

@pepone
Copy link
Member

pepone commented Jan 15, 2021 •
edited
Loading

ice-builder-msbuild/msbuild/zeroc.icebuilder.msbuild.cpp.targets

Line 106 in aec00b7

<ClCompile Include="@(_SliceCompile->'%(OutputDir)\%(Filename).%(SourceExt)')"

Here the %(OutputDir) is not normalized, and depending on how it is specified in the project property, it will match or not the Excludes attribute.

We need to review other places where it is used for comparisons and always normalize it
@pepone pepone added the bug label Jan 15, 2021
@pepone pepone self-assigned this Jan 15, 2021
pepone added a commit to pepone/ice-builder-msbuild that referenced this issue Jan 15, 2021
@pepone
Fix bogus metadata included in generated items - Close zeroc-ice#6 ze…
35c3c0e 
…roc-ice#7
@pepone
Copy link
Member Author

pepone commented Jan 16, 2021

Fixed in #8

@pepone pepone closed this as completed Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pepone pepone

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pepone