Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subsys: console: Mark as EXPERIMENTAL. #9325

Merged

Conversation

pfalcon
Copy link
Contributor

@pfalcon pfalcon commented Aug 7, 2018

This subsys is in the process of collecting requirements/usecases,
the API is subject to change. (Should have been marked experimental
from the beginning.)

Signed-off-by: Paul Sokolovsky paul.sokolovsky@linaro.org

This subsys is in the process of collecting requirements/usecases,
the API is subject to change. (Should have been marked experimental
from the beginning.)

Signed-off-by: Paul Sokolovsky <paul.sokolovsky@linaro.org>
@pfalcon
Copy link
Contributor Author

pfalcon commented Aug 7, 2018

The API details are being discussed with @andrewboie (hopefully other parties will join too), and definitely going to change. As written in the commit message, should have been marked experimental from the beginning.

@carlescufi
Copy link
Member

Is this related to the new console/shell module being proposed here: #9362 ?

@pfalcon
Copy link
Contributor Author

pfalcon commented Aug 9, 2018

Is this related to the new console/shell module being proposed here: #9362 ?

No.

@nashif nashif closed this Aug 11, 2018
@nashif nashif reopened this Aug 11, 2018
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@0b01225). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9325   +/-   ##
=========================================
  Coverage          ?   52.58%           
=========================================
  Files             ?      201           
  Lines             ?    25351           
  Branches          ?     5304           
=========================================
  Hits              ?    13331           
  Misses            ?     9921           
  Partials          ?     2099

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b01225...97d284a. Read the comment docs.

@pfalcon pfalcon added this to the v1.13.0 milestone Aug 14, 2018
@pfalcon
Copy link
Contributor Author

pfalcon commented Aug 14, 2018

@nashif: ping

@nashif nashif merged commit 78d2476 into zephyrproject-rtos:master Aug 14, 2018
@pfalcon pfalcon deleted the subsys-console-experimental branch September 6, 2018 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants