dts: bindings: stepper: use hyphens instead of underscore #83842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
|
That's great! But it seems there are no changes to the DTS files. Hopefully, we didn't miss any DTS files. |
rruuaanng
previously approved these changes
Jan 11, 2025
faxe1008
previously approved these changes
Jan 11, 2025
bjarki-andreasen
previously approved these changes
Jan 11, 2025
fabiobaltieri
previously approved these changes
Jan 12, 2025
kartben
requested changes
Jan 15, 2025
|
Perhaps the proposed changes will be implemented in the 4.1 release. Adding a migration for version 4.1 might be more appropriate, as these property names are still present in the 4.0 release. |
This commit replaces hyphens with underscore in order to comply with devicetree standards Signed-off-by: Jilay Pandya <jilay.pandya@outlook.com>
2263c6d
458d326 to
2263c6d
Compare
rruuaanng
reviewed
Jan 16, 2025
doc/releases/migration-guide-4.1.rst
Outdated
| @@ -279,6 +279,17 @@ Stepper | |||
| :kconfig:option:`STEPPER_ADI_TMC5041_RAMP_GEN` option. | |||
| * To control the velocity for :dtcompatible:`adi,tmc5041` stepper driver, use | |||
| :c:func:`tmc5041_stepper_set_max_velocity` or :c:func:`tmc5041_stepper_set_ramp`. | |||
| * Renamed following DeviceTree properties: | |||
There was a problem hiding this comment.
Perhaps listing them individually would be better, as there are too many of them, and this approach would align better with the existing style of the migration entry.
E.g.
* Renamed the devicetree property ``en_spreadcycle`` to ``en-spreadcycle``.
* ...
add migration guide for following renamed variables - ``en_spreadcycle`` to ``en-spreadcycle`` - ``i_scale_analog`` to ``i-scale-analog`` - ``index_optw``to ``index-otpw``` - ``ìndex_step`` to ``index-step`` - ``internal_rsense`` to ``internal-rsense`` - ``lock_gconf`` to ``lock-gconf`` - ``mstep_reg_select`` to ``mstep-reg-select`` - ``pdn_disable`` to ``pdn-disable`` - ``poscmp_enable`` to ``poscmp-enable`` - ``test_mode`` to ``test-mode`` Signed-off-by: Jilay Pandya <jilay.pandya@outlook.com>
2263c6d to
01572d6
Compare
dipakgmx
approved these changes
Jan 16, 2025
fabiobaltieri
approved these changes
Jan 16, 2025
@kartben Done |
kartben
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces hyphens with underscore in order to comply with devicetree standards