Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable -Wmissing-braces warning for clang #83835

Merged

Conversation

thughes
Copy link
Contributor

@thughes thughes commented Jan 11, 2025

All warnings in the code base have been resolved.

@thughes thughes force-pushed the fix-missing-braces-warnings branch from e9883f7 to bf6f621 Compare January 13, 2025 20:01
@thughes thughes changed the title cmake clang/compiler_flags.cmake: Re-enable Wmissing-braces warning Re-enable -Wmissing-braces warning for clang Jan 13, 2025
@thughes thughes marked this pull request as ready for review January 13, 2025 22:26
@thughes thughes changed the title Re-enable -Wmissing-braces warning for clang Re-enable -Wmissing-braces warning for clang Jan 13, 2025
@zephyrbot zephyrbot added area: Toolchains Toolchains size: XS A PR changing only a single line of code area: Build System labels Jan 13, 2025
tejlmand
tejlmand previously approved these changes Jan 14, 2025
kartben
kartben previously approved these changes Jan 14, 2025
yperess
yperess previously approved these changes Jan 14, 2025
nordicjm
nordicjm previously approved these changes Jan 15, 2025
@kartben
Copy link
Collaborator

kartben commented Jan 16, 2025

@thughes please rebase

All warnings in the code base have been resolved.

Signed-off-by: Tom Hughes <tomhughes@chromium.org>
@thughes thughes dismissed stale reviews from nordicjm, yperess, kartben, and tejlmand via fb0b31f January 16, 2025 17:15
@thughes thughes force-pushed the fix-missing-braces-warnings branch from bf6f621 to fb0b31f Compare January 16, 2025 17:15
@kartben kartben merged commit c021c6d into zephyrproject-rtos:main Jan 17, 2025
24 checks passed
@thughes thughes deleted the fix-missing-braces-warnings branch January 17, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Build System area: Toolchains Toolchains size: XS A PR changing only a single line of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants