scripts: west_commands: runners: fix support for JLink RTT #83832
+12
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JLink refuses new RTT telnet connections for a few moments after a socket closes. This causes an issue when using
nc
as the telnet viewer, since JLink would deny the connection. To resolve this, keep the "ping" socket we use to determine if the RTT viewer is active connected, and use that socket for RTT communication.Another solution here would be to simply increase the delay before opening the
nc
connection- however I think this approach makes less sense, as it will increase latency when startingwest rtt
. Moreover, it isn't clear exactly how long JLink will deny new connections for, so the new delay would be arbitrary